[BUGFIX] Fix indexing of access protected pages #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmack
approved these changes
Oct 5, 2023
dkd-kaehm
approved these changes
Oct 5, 2023
Tests/Integration/IndexQueue/FrontendHelper/PageIndexerTest.php
Outdated
Show resolved
Hide resolved
dkd-friedrich
force-pushed
the
bugfix/main/3735-fix_access_protected_page_indexing
branch
from
11fef4e to
e6a6981
Compare
|
I've added more tests and fixes, e.g. the test for invalid item handling. I did some minor, not directly related cleanup and improvements additionally, thus the commits shouldn't be squashed! |
dkd-kaehm
reviewed
Oct 10, 2023
Fixes indexing of access protected pages and/or page contents. Resolves: TYPO3-Solr#3735
Cleans and optimizes the frontend helper "PageIndexer" integration test. Failure test for non existing pages/sites is refactored and PageIndexer adapted, even if AfterCacheableContentIsGeneratedEvent is not dispatched e.g. as the page is not found, the response will always contain the pageIndexed flag. Additionally the methods of PageIndexer that were defined as public to simplify testing are now protected, the tests are adapted accordingly. If you have used this methods, you have to adapt your code. Affected methods: - setupConfiguration - index - indexPage Relates: TYPO3-Solr#3735
dkd-kaehm
force-pushed
the
bugfix/main/3735-fix_access_protected_page_indexing
branch
from
e6a6981 to
9121e87
Compare
dkd-kaehm
deleted the
bugfix/main/3735-fix_access_protected_page_indexing
branch
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Oct 13, 2023
This change is the follow-up of TYPO3-Solr@a6168bcc6 Relates: TYPO3-Solr#3735, TYPO3-Solr#3811
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Oct 13, 2023
This change is the follow-up of TYPO3-Solr@a6168bcc6 Relates: TYPO3-Solr#3735, TYPO3-Solr#3811
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Oct 13, 2023
This change is the follow-up of TYPO3-Solr@a6168bcc6 Relates: TYPO3-Solr#3735, TYPO3-Solr#3811
|
We have the same problem on v11 of this extension. Is this fix only for v12? |
@agendartobias Which version exactly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Fixes indexing of access protected pages and/or page contents.
How to test
Configure access protected pages/page contents and check indexing, e.g.
Resolves: #3735
Caution: PR contains an additional cleanup/improvement commit that is no directly related, commits shouldn't be squashed!