[!!!][TASK] Remove deprecated Node class #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Originates from #3665 |
dkd-friedrich
force-pushed
the
task/main/3630-replace_node_with_endpoint
branch
from
72adf9b to
3e1cb41
Compare
|
Necessary adjustments made, final tests are still pending We have to decide if we still want to support the |
We discussed this and we'll drop this backwards compatibility with EXT:solr 12, to reduce the complexity and to follow the standards. |
dkd-friedrich
force-pushed
the
task/main/3630-replace_node_with_endpoint
branch
3 times, most recently
from
262474f to
f6e7fd4
Compare
dkd-kaehm
force-pushed
the
task/main/3630-replace_node_with_endpoint
branch
from
f6e7fd4 to
666529c
Compare
Removes deprecated class ApacheSolrForTypo3\Solr\System\Solr\Node and it's usages. - Replace deprecated Node class with Endpoint - Replace getUsername/getPassword with getAuthentication() - Change SolrConnection->getNode() to SolrConnection->getEndpoint Resolves: TYPO3-Solr#3630, TYPO3-Solr#3043 Replaces: TYPO3-Solr#3518
dkd-kaehm
force-pushed
the
task/main/3630-replace_node_with_endpoint
branch
from
666529c to
53d4c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
Removes deprecated class ApacheSolrForTypo3\Solr\System\Solr\Node and it's usages.
Resolves: #3630