Skip to content

Commit

Permalink
[BUGFIX] Fix missing frontend.typoscript request attribute while inde…
Browse files Browse the repository at this point in the history
…xing

Fixes: #3751
  • Loading branch information
tillhoerner committed Aug 16, 2023
1 parent b15df83 commit d6acef6
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Classes/FrontendEnvironment/Tsfe.php
Original file line number Diff line number Diff line change
Expand Up @@ -168,10 +168,9 @@ protected function initializeTsfe(int $pageId, int $language = 0, ?int $rootPage
$backedUpBackendUser = $GLOBALS['BE_USER'] ?? null;
try {
$tsfe->determineId($serverRequest);
$serverRequest->withAttribute('frontend.controller', $tsfe);
$serverRequest = $serverRequest->withAttribute('frontend.controller', $tsfe);
$tsfe->no_cache = false;
// @todo T12: Check if following line really needed
$tsfe->getFromCache($serverRequest);
$serverRequest = $tsfe->getFromCache($serverRequest);
// The manual releasing of locks is low level api and should be avoided in EXT:solr.
$tsfe->releaseLocks();

Expand All @@ -193,6 +192,7 @@ protected function initializeTsfe(int $pageId, int $language = 0, ?int $rootPage
$GLOBALS['BE_USER'] = $backedUpBackendUser;
}

$this->serverRequestCache[$cacheIdentifier] = $serverRequest;

Check failure on line 195 in Classes/FrontendEnvironment/Tsfe.php

View workflow job for this annotation

GitHub Actions / TYPO3 12 on PHP 8.1

Property ApacheSolrForTypo3\Solr\FrontendEnvironment\Tsfe::$serverRequestCache (array<TYPO3\CMS\Core\Http\ServerRequest>) does not accept array<Psr\Http\Message\ServerRequestInterface>.

Check failure on line 195 in Classes/FrontendEnvironment/Tsfe.php

View workflow job for this annotation

GitHub Actions / TYPO3 12.4.x-dev on PHP 8.1

Property ApacheSolrForTypo3\Solr\FrontendEnvironment\Tsfe::$serverRequestCache (array<TYPO3\CMS\Core\Http\ServerRequest>) does not accept array<Psr\Http\Message\ServerRequestInterface>.

Check failure on line 195 in Classes/FrontendEnvironment/Tsfe.php

View workflow job for this annotation

GitHub Actions / TYPO3 12 on PHP 8.2

Property ApacheSolrForTypo3\Solr\FrontendEnvironment\Tsfe::$serverRequestCache (array<TYPO3\CMS\Core\Http\ServerRequest>) does not accept array<Psr\Http\Message\ServerRequestInterface>.

Check failure on line 195 in Classes/FrontendEnvironment/Tsfe.php

View workflow job for this annotation

GitHub Actions / TYPO3 12.4.x-dev on PHP 8.2

Property ApacheSolrForTypo3\Solr\FrontendEnvironment\Tsfe::$serverRequestCache (array<TYPO3\CMS\Core\Http\ServerRequest>) does not accept array<Psr\Http\Message\ServerRequestInterface>.

Check failure on line 195 in Classes/FrontendEnvironment/Tsfe.php

View workflow job for this annotation

GitHub Actions / TYPO3 12 on PHP 8.3

Property ApacheSolrForTypo3\Solr\FrontendEnvironment\Tsfe::$serverRequestCache (array<TYPO3\CMS\Core\Http\ServerRequest>) does not accept array<Psr\Http\Message\ServerRequestInterface>.

Check failure on line 195 in Classes/FrontendEnvironment/Tsfe.php

View workflow job for this annotation

GitHub Actions / TYPO3 12.4.x-dev on PHP 8.3

Property ApacheSolrForTypo3\Solr\FrontendEnvironment\Tsfe::$serverRequestCache (array<TYPO3\CMS\Core\Http\ServerRequest>) does not accept array<Psr\Http\Message\ServerRequestInterface>.
$this->tsfeCache[$cacheIdentifier] = $tsfe;
}

Expand Down

0 comments on commit d6acef6

Please sign in to comment.