-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Get correct page id for a shortcut #672
[BUGFIX] Get correct page id for a shortcut #672
Conversation
Pull Request Test Coverage Report for Build 6850008836Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
e754175
to
a980f79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you cover this with tests?
By the way: is this really an issue? I mean, it's OK to have id of shortcut page, as it's redirected by 307 HTTP to other page, or I don't understand your issue.
My use case involves two Typo3 root pages in one backend, let's call them Page A and Page B. On Page A, i'm building a menu using the Menubuilder, and within this menu, i have links to Page B. In the Typo3 site config, i have defined the frontend URL as a.site.com and the backend URL as api.a.site.com. Similarly, Page B has frontend URL b.site.com and backend URL api.b.site.com. When i build the menu, the links are generated as a.site.com instead of the expected b.site.com. This is happening because the Site Configuration of Page A is being used to get the frontend url, and Page B's Site Configuration is not being used as expected. |
@twoldanski No, unfortunately, your merge request could not resolve my issue. |
Hi @KrohnMi could you provide example typoscript to reproduce your issue? |
@KrohnMi please provide some examples so we can reproduce this issue |
When creating a shortcut in TYPO3 that points to a different root page, an incorrect link is generated.
I hope I have fixed it correctly.