Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Correct linkText value in headerLink property #667

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

schloram
Copy link
Contributor

@schloram schloram commented Nov 6, 2023

Due to the additional option field = header_link setting the output of linkText value was always something like t3://page?uid=13 for internal links. But it would be better to let typolink always handle the linkText to have it replaced with e.g the page title.

Current:

"headerLink": {
  "href": "/my-page",
  "target": null,
  "class": null,
  "title": null,
  "linkText": "t3://page?uid=13",
  "additionalAttributes": []
}

Fixed:

"headerLink": {
  "href": "/my-page",
  "target": null,
  "class": null,
  "title": null,
  "linkText": "My Page",
  "additionalAttributes": []
}

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6785483387

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.328%

Totals Coverage Status
Change from base Build 6772803664: 0.0%
Covered Lines: 822
Relevant Lines: 1298

💛 - Coveralls

@lukaszuznanski
Copy link
Collaborator

@schloram thanks for this PR, I'm merging it into master, could you also provide one for version 3.x? You need to create new branch out of 3.x and create PR to 3.x.

Thanks!

@lukaszuznanski lukaszuznanski merged commit 043f1af into TYPO3-Headless:master Nov 7, 2023
7 checks passed
@schloram
Copy link
Contributor Author

@lukaszuznanski Done. -> #673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants