Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Overhaul #6

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Code Overhaul #6

wants to merge 45 commits into from

Conversation

davschneller
Copy link
Contributor

@davschneller davschneller commented Jul 12, 2024

We add two new features:

  • The logger format was adapted to display the year and milliseconds, but not the day of the week anymore. It also optionally allows output from all ranks now—and it will print the rank where the info is from (possible overlap to fix logger to write for all ranks #5 ). Furthermore, it is now able to print iterators (e.g. vectors) and structured bindings (e.g. tuples). Also, the rank is now set globally—thus making the tedious rank specification for info messages each time obsolete.
  • The environment variables are now cached by default.

Furthermore, we format and tidy the code, and shorten the license headers to the necessary information [TODO: that'll need conformation if ok or not—all authors so far have been placed into the AUTHORS.txt file]. Also, we implement the REUSE specification for this project now.

The CI is also reactivated. Old functions (which are now in the standard) are removed.

A snippet with the new log format:

2024-11-11 13:04:30.027 info 0 : Number of record points = 6 
2024-11-11 13:04:30.027 info 0 : Finding meshIds for receivers... 
2024-11-11 13:04:30.027 info 0 : Cleaning possible double occurring receivers for MPI... 
2024-11-11 13:04:30.027 info 0 : Mapping receivers to LTS cells... 
2024-11-11 13:04:30.027 info 0 : Initializing energy output. 
2024-11-11 13:04:30.027 info 0 : End init output. 
2024-11-11 13:04:30.028 info 0 : Finishing initialization... 
2024-11-11 13:04:30.028 info 0 : Starting simulation. 
2024-11-11 13:04:30.032 info 0 : Writing faultoutput at time 0.
2024-11-11 13:04:30.180 info 0 : Writing faultoutput at time 0. Done.
2024-11-11 13:04:30.180 info 0 : Waiting for last wave field. 
2024-11-11 13:04:30.180 info 0 : Writing wave field at time 0.
2024-11-11 13:04:30.254 info 0 : Writing wave field at time 0. Done.
2024-11-11 13:04:30.254 info 0 : Writing energy output at time 0 
2024-11-11 13:04:30.476 info 0 :  Total momentum (X, Y, Z): 0  , 0  , 0 
2024-11-11 13:04:30.476 info 0 : Writing energy output at time 0 Done. 
2024-11-11 13:04:30.476 info 0 : Time spent for initial IO: 447.8533 ms (min: 447.8533 ms, max: 447.8533 ms)
2024-11-11 13:04:46.367 info 0 : Writing faultoutput at time 1.
2024-11-11 13:04:46.476 info 0 : Writing faultoutput at time 1. Done.
2024-11-11 13:04:46.477 info 0 : Waiting for last wave field. 

@davschneller davschneller marked this pull request as ready for review November 20, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants