Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalizing clustering output #11

Merged
merged 1 commit into from
Feb 6, 2024
Merged

generalizing clustering output #11

merged 1 commit into from
Feb 6, 2024

Conversation

Thomas-Ulrich
Copy link
Contributor

required for:
SeisSol/SeisSol#1024

@Thomas-Ulrich Thomas-Ulrich mentioned this pull request Feb 5, 2024
Merged
@Thomas-Ulrich Thomas-Ulrich force-pushed the thomas/change_for_tagging branch from 772c976 to cab059b Compare February 6, 2024 07:42
davschneller
davschneller approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@davschneller davschneller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, LGTM so far. Only a short question: is it safe to remove the clustering info completely?

@Thomas-Ulrich
Copy link
Contributor Author

It is not removed, it is only renamed to extraIntCellVariableName.
See e.g. changes in
src/ResultWriter/WaveFieldWriterExecutor.h in https://github.com/SeisSol/SeisSol/pull/1024/files

@davschneller davschneller merged commit 55ef56f into TUM-I5:master Feb 6, 2024
0 of 4 checks passed
@Thomas-Ulrich Thomas-Ulrich mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davschneller davschneller davschneller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thomas-Ulrich @davschneller