Pass preferences to BrowserWindows via command line arguments #1131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context / Background
The 3 browser windows we create from main start by doing a reverse call back into main to ask for the user preferences.
The idea of this PR is to pass the preferences as a stringfied JSON via the command line arguments of the Browser Windows. They can be retrieved on the renderer preload scripts from window.process.argv. That should speed up creation of windows and allows us to remove the ipcRenderer dependency function to get user preferences from the renderer.
What change is being introduced by this PR?
How will this be tested?
App is working fine, tests are passing.