Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements: upgrade numpy #161

Merged
merged 1 commit into from
Jan 31, 2024
Merged

requirements: upgrade numpy #161

merged 1 commit into from
Jan 31, 2024

Conversation

chrisochoatri
Copy link
Collaborator

@chrisochoatri chrisochoatri commented Jan 30, 2024 •
edited
Loading

  • upgrades the minimum version of numpy
  • updates minimum xarray (pinned version was not compatible with numpy 1.20.3)
  • uses a newer cython for building

This change is Reviewable

yuta-tsuzuki-woven
yuta-tsuzuki-woven approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@yuta-tsuzuki-woven yuta-tsuzuki-woven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @chrisochoatri)

@chrisochoatri chrisochoatri merged commit ac4c2a6 into TRI-ML:master Jan 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuta-tsuzuki-woven yuta-tsuzuki-woven yuta-tsuzuki-woven approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisochoatri @yuta-tsuzuki-woven