Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test failure stack traces to JUnit reports #25

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

buntagonalprism
Copy link

Stack traces were previously deliberately excluded from the JUnit output when a test failed an expectation like expect(true, false). Stack traces were only included when an unexpected error was encountered while running the test.

This change includes the stack trace in the JUnit output for test failures, as well as test errors.

An example of where stack traces for test failures may be useful: consider a large application that is using helper methods to verify common behaviour. In this case the failing expectation may not be collocated with the failing test, so having the stack trace is crucial in quickly finding where the issue is occurring.

Also swapped the escaped newline characters in the error for true newlines, which produces a cleaner output.

Fixes #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding stack traces in xml_reports.
2 participants