Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix flag annotations #58

Merged
merged 10 commits into from
Oct 3, 2023
Merged

Bugfix flag annotations #58

merged 10 commits into from
Oct 3, 2023

Conversation

ckitsanelis
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@TuenDeBuis TuenDeBuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some refactoring and then LGTM!

src/viewer/App.tsx Outdated Show resolved Hide resolved
src/viewer/LogFile.tsx Outdated Show resolved Hide resolved
src/viewer/LogFile.tsx Outdated Show resolved Hide resolved
src/viewer/LogFile.tsx Outdated Show resolved Hide resolved
src/viewer/LogFile.tsx Outdated Show resolved Hide resolved
src/viewer/rules/Dialogs/FlagsDialog.tsx Outdated Show resolved Hide resolved
src/viewer/rules/Dialogs/StatesDialog.tsx Outdated Show resolved Hide resolved
@TuenDeBuis
Copy link
Collaborator

Looks Good To Me!

Copy link
Collaborator

@TuenDeBuis TuenDeBuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TuenDeBuis TuenDeBuis merged commit 65b4e86 into main Oct 3, 2023
2 checks passed
@TuenDeBuis TuenDeBuis deleted the bugfix-flag-annotations branch October 3, 2023 09:04
@ckitsanelis ckitsanelis linked an issue Oct 3, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly defined flag annotation columns is hidden and cannot be shown
2 participants