Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filtering and improve serilizer #715

Merged
merged 2 commits into from
Oct 9, 2023
Merged

fix: filtering and improve serilizer #715

merged 2 commits into from
Oct 9, 2023

Conversation

martcl
Copy link
Contributor

@martcl martcl commented Oct 9, 2023

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Banner filtering var broken og vi bør ikke sortere på custom modell properies. Prøvde å finne eksempler, men det er anbefalt å bare sortere på vanlige modell properties

Issue number: closes #

Pull request checklist

Please check if your PR fulfills the following requirements:

  • CHANGELOG.md has been updated. Guide
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • The fixtures have been updated if needed (for migrations)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@martcl martcl requested a review from thomsen85 October 9, 2023 16:34
@thomsen85
Copy link
Contributor

Funka ikke de propertyene?

@martcl martcl merged commit 1c5952f into dev Oct 9, 2023
@martcl martcl deleted the fix/banners branch October 9, 2023 16:39
@martcl
Copy link
Contributor Author

martcl commented Oct 9, 2023

Nope...

@martcl
Copy link
Contributor Author

martcl commented Oct 9, 2023

Men bruker propertiene for å sende dem til frontend. Da kan vi gi aktiv en annen farge eller noe sånt

@thomsen85
Copy link
Contributor

💀 jaja, får ta å fjerne de då

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants