refactored exception for order init error #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomsen85
approved these changes
Oct 13, 2023
| @@ -2,6 +2,11 @@ | |||
| from rest_framework.exceptions import APIException | |||
|
|
|||
|
|
|||
| class APIEventIsPaidEventException(APIException): | |||
There was a problem hiding this comment.
Formater navnet som en feil
APIPaidEventCantBeChangedToFreeEvent(APIException)
typ
MadsNyl
added a commit
that referenced
this pull request
Oct 23, 2023
* refactored exception for order init error (#712) * refactored exception for order init error * added error when trying to update a paid event to a free event * Refactor(paid event)/rename exception (#717) * refactored exception for order init error * added error when trying to update a paid event to a free event * changed name of exception * Trigger Build * notification for waiting list and when coming from waiting list (#725) * use env variable for celery broker url (#726) * chore: use env variable for celery broker url * chore: set default env varibale if not configured * Give HS user permissions (#727) * Give HS user permissions * Fix * Update CHANGELOG.md --------- Co-authored-by: Martin Clementz <[email protected]> Co-authored-by: Thomas H. Svendal <[email protected]>
MadsNyl
added a commit
that referenced
this pull request
Nov 6, 2023
* refactored exception for order init error (#712) * refactored exception for order init error * added error when trying to update a paid event to a free event * Refactor(paid event)/rename exception (#717) * refactored exception for order init error * added error when trying to update a paid event to a free event * changed name of exception * Trigger Build * notification for waiting list and when coming from waiting list (#725) * use env variable for celery broker url (#726) * chore: use env variable for celery broker url * chore: set default env varibale if not configured * Give HS user permissions (#727) * Give HS user permissions * Fix * Update CHANGELOG.md * Feat(event)/waitlist (#724) * Fix(registration)/waitlist limit (#729) * users from wait list get bumped up if event limit is increased, and users from queue get bumped down if the limit is decreased. Priority is respected * format * altered test with bigger dicrease, and to test if priority is respected * added endpotint for manually adding members to an event (#730) * added endpotint for manually adding members to an event * format * made migrations * test for registration on wait list if event is full * Feat(qr)/qr generator (#719) * added model for QR code, viewset and serializer * finished create and destroy methods, and mades tests for these * altered create viewset to take user from request * fixed tests * changed status code for deletion of qr code to 200 since frontend dosent accept 204 status code.... * format * removed earlier unused method * format * Trigger Build * changed exception to take all errors with making a blob * format * added azure key to settings file * format * changed name of exception for blbo not found * altered ci.yaml file to add azure connecntion string as env * fix ci file * changed model to take content, and serializer not upload image to azure * format * added users and groups to fixture (#731) * made it possible to add members before and after registration open time (#733) * made it possible to add members before and after registration open time * can add for paid event * format * format * Update CHANGELOG.md --------- Co-authored-by: Martin Clementz <[email protected]> Co-authored-by: Thomas H. Svendal <[email protected]> Co-authored-by: Anders <[email protected]>
MadsNyl
added a commit
that referenced
this pull request
Nov 16, 2023
* refactored exception for order init error (#712) * refactored exception for order init error * added error when trying to update a paid event to a free event * Refactor(paid event)/rename exception (#717) * refactored exception for order init error * added error when trying to update a paid event to a free event * changed name of exception * Trigger Build * notification for waiting list and when coming from waiting list (#725) * use env variable for celery broker url (#726) * chore: use env variable for celery broker url * chore: set default env varibale if not configured * Give HS user permissions (#727) * Give HS user permissions * Fix * Update CHANGELOG.md * Feat(event)/waitlist (#724) * Fix(registration)/waitlist limit (#729) * users from wait list get bumped up if event limit is increased, and users from queue get bumped down if the limit is decreased. Priority is respected * format * altered test with bigger dicrease, and to test if priority is respected * added endpotint for manually adding members to an event (#730) * added endpotint for manually adding members to an event * format * made migrations * test for registration on wait list if event is full * Feat(qr)/qr generator (#719) * added model for QR code, viewset and serializer * finished create and destroy methods, and mades tests for these * altered create viewset to take user from request * fixed tests * changed status code for deletion of qr code to 200 since frontend dosent accept 204 status code.... * format * removed earlier unused method * format * Trigger Build * changed exception to take all errors with making a blob * format * added azure key to settings file * format * changed name of exception for blbo not found * altered ci.yaml file to add azure connecntion string as env * fix ci file * changed model to take content, and serializer not upload image to azure * format * added users and groups to fixture (#731) * made it possible to add members before and after registration open time (#733) * made it possible to add members before and after registration open time * can add for paid event * format * format * Update CHANGELOG.md * Activity (#736) * first version * changed ordering for activities * filled out categiory enum * fixed test * fixed test again * Update CHANGELOG.md --------- Co-authored-by: Martin Clementz <[email protected]> Co-authored-by: Thomas H. Svendal <[email protected]> Co-authored-by: Anders <[email protected]>
MadsNyl
added a commit
that referenced
this pull request
Jan 15, 2024
* refactored exception for order init error (#712) * refactored exception for order init error * added error when trying to update a paid event to a free event * Refactor(paid event)/rename exception (#717) * refactored exception for order init error * added error when trying to update a paid event to a free event * changed name of exception * Trigger Build * notification for waiting list and when coming from waiting list (#725) * use env variable for celery broker url (#726) * chore: use env variable for celery broker url * chore: set default env varibale if not configured * Give HS user permissions (#727) * Give HS user permissions * Fix * Update CHANGELOG.md * Feat(event)/waitlist (#724) * Fix(registration)/waitlist limit (#729) * users from wait list get bumped up if event limit is increased, and users from queue get bumped down if the limit is decreased. Priority is respected * format * altered test with bigger dicrease, and to test if priority is respected * added endpotint for manually adding members to an event (#730) * added endpotint for manually adding members to an event * format * made migrations * test for registration on wait list if event is full * Feat(qr)/qr generator (#719) * added model for QR code, viewset and serializer * finished create and destroy methods, and mades tests for these * altered create viewset to take user from request * fixed tests * changed status code for deletion of qr code to 200 since frontend dosent accept 204 status code.... * format * removed earlier unused method * format * Trigger Build * changed exception to take all errors with making a blob * format * added azure key to settings file * format * changed name of exception for blbo not found * altered ci.yaml file to add azure connecntion string as env * fix ci file * changed model to take content, and serializer not upload image to azure * format * added users and groups to fixture (#731) * made it possible to add members before and after registration open time (#733) * made it possible to add members before and after registration open time * can add for paid event * format * format * Update CHANGELOG.md * Activity (#736) * first version * changed ordering for activities * filled out categiory enum * fixed test * fixed test again * Update CHANGELOG.md * Added filter for expired and upcoming events (#714) * Added filter for expired and upcoming events * Removed registration filter on event has ended * Added manual filtering for expired events in user viewset * Removed unused import * Started testing expired event method * Finished testing filter methode * format * removed incorrect True comparison * Updated changlog * Added tests where query params give false * Used CaseInsensitiveBooleanQueryParam for handling all types of query params + removed comments * Fixed typo * Formatting --------- Co-authored-by: Harry Linrui XU <[email protected]> Co-authored-by: haruixu <[email protected]> * fixed bug with added order. set the status to SALE. Added 400 status … (#742) fixed bug with added order. set the status to SALE. Added 400 status for adding registration for existing user * fixed issue expired events (#743) * fixed issue expired events * needs a fix * fixed bugs * format * format * fixed filtering * feat(emojis): added emojis (#553) * added emoji dependency * created emoji app* removed unused files * added emoji models, serializers and views * added urls for emoji app
* fixed models and added basic admin * added view for unicode emojis * ever closer to the end
* fixed emoji serializers * fixed model admin * is ready?
thomsen85
added a commit
that referenced
this pull request
Jan 15, 2024
January Update (#750) * refactored exception for order init error (#712) * refactored exception for order init error * added error when trying to update a paid event to a free event * Refactor(paid event)/rename exception (#717) * refactored exception for order init error * added error when trying to update a paid event to a free event * changed name of exception * Trigger Build * notification for waiting list and when coming from waiting list (#725) * use env variable for celery broker url (#726) * chore: use env variable for celery broker url * chore: set default env varibale if not configured * Give HS user permissions (#727) * Give HS user permissions * Fix * Update CHANGELOG.md * Feat(event)/waitlist (#724) * Fix(registration)/waitlist limit (#729) * users from wait list get bumped up if event limit is increased, and users from queue get bumped down if the limit is decreased. Priority is respected * format * altered test with bigger dicrease, and to test if priority is respected * added endpotint for manually adding members to an event (#730) * added endpotint for manually adding members to an event * format * made migrations * test for registration on wait list if event is full * Feat(qr)/qr generator (#719) * added model for QR code, viewset and serializer * finished create and destroy methods, and mades tests for these * altered create viewset to take user from request * fixed tests * changed status code for deletion of qr code to 200 since frontend dosent accept 204 status code.... * format * removed earlier unused method * format * Trigger Build * changed exception to take all errors with making a blob * format * added azure key to settings file * format * changed name of exception for blbo not found * altered ci.yaml file to add azure connecntion string as env * fix ci file * changed model to take content, and serializer not upload image to azure * format * added users and groups to fixture (#731) * made it possible to add members before and after registration open time (#733) * made it possible to add members before and after registration open time * can add for paid event * format * format * Update CHANGELOG.md * Activity (#736) * first version * changed ordering for activities * filled out categiory enum * fixed test * fixed test again * Update CHANGELOG.md * Added filter for expired and upcoming events (#714) * Added filter for expired and upcoming events * Removed registration filter on event has ended * Added manual filtering for expired events in user viewset * Removed unused import * Started testing expired event method * Finished testing filter methode * format * removed incorrect True comparison * Updated changlog * Added tests where query params give false * Used CaseInsensitiveBooleanQueryParam for handling all types of query params + removed comments * Fixed typo * Formatting --------- * fixed bug with added order. set the status to SALE. Added 400 status … (#742) fixed bug with added order. set the status to SALE. Added 400 status for adding registration for existing user * fixed issue expired events (#743) * fixed issue expired events * needs a fix * fixed bugs * format * format * fixed filtering * feat(emojis): added emojis (#553) * added emoji dependency * created emoji app
MadsNyl
added a commit
that referenced
this pull request
Jan 15, 2024
* refactored exception for order init error (#712) * refactored exception for order init error * added error when trying to update a paid event to a free event * Refactor(paid event)/rename exception (#717) * refactored exception for order init error * added error when trying to update a paid event to a free event * changed name of exception * Trigger Build * notification for waiting list and when coming from waiting list (#725) * use env variable for celery broker url (#726) * chore: use env variable for celery broker url * chore: set default env varibale if not configured * Give HS user permissions (#727) * Give HS user permissions * Fix * Update CHANGELOG.md * Feat(event)/waitlist (#724) * Fix(registration)/waitlist limit (#729) * users from wait list get bumped up if event limit is increased, and users from queue get bumped down if the limit is decreased. Priority is respected * format * altered test with bigger dicrease, and to test if priority is respected * added endpotint for manually adding members to an event (#730) * added endpotint for manually adding members to an event * format * made migrations * test for registration on wait list if event is full * Feat(qr)/qr generator (#719) * added model for QR code, viewset and serializer * finished create and destroy methods, and mades tests for these * altered create viewset to take user from request * fixed tests * changed status code for deletion of qr code to 200 since frontend dosent accept 204 status code.... * format * removed earlier unused method * format * Trigger Build * changed exception to take all errors with making a blob * format * added azure key to settings file * format * changed name of exception for blbo not found * altered ci.yaml file to add azure connecntion string as env * fix ci file * changed model to take content, and serializer not upload image to azure * format * added users and groups to fixture (#731) * made it possible to add members before and after registration open time (#733) * made it possible to add members before and after registration open time * can add for paid event * format * format * Update CHANGELOG.md * Activity (#736) * first version * changed ordering for activities * filled out categiory enum * fixed test * fixed test again * Update CHANGELOG.md * Added filter for expired and upcoming events (#714) * Added filter for expired and upcoming events * Removed registration filter on event has ended * Added manual filtering for expired events in user viewset * Removed unused import * Started testing expired event method * Finished testing filter methode * format * removed incorrect True comparison * Updated changlog * Added tests where query params give false * Used CaseInsensitiveBooleanQueryParam for handling all types of query params + removed comments * Fixed typo * Formatting --------- Co-authored-by: Harry Linrui XU <[email protected]> Co-authored-by: haruixu <[email protected]> * fixed bug with added order. set the status to SALE. Added 400 status … (#742) fixed bug with added order. set the status to SALE. Added 400 status for adding registration for existing user * fixed issue expired events (#743) * fixed issue expired events * needs a fix * fixed bugs * format * format * fixed filtering * feat(emojis): added emojis (#553) * added emoji dependency * created emoji app
martcl
added a commit
that referenced
this pull request
Jan 16, 2024
* January Update (#750) * refactored exception for order init error (#712) * refactored exception for order init error * added error when trying to update a paid event to a free event * Refactor(paid event)/rename exception (#717) * refactored exception for order init error * added error when trying to update a paid event to a free event * changed name of exception * Trigger Build * notification for waiting list and when coming from waiting list (#725) * use env variable for celery broker url (#726) * chore: use env variable for celery broker url * chore: set default env varibale if not configured * Give HS user permissions (#727) * Give HS user permissions * Fix * Update CHANGELOG.md * Feat(event)/waitlist (#724) * Fix(registration)/waitlist limit (#729) * users from wait list get bumped up if event limit is increased, and users from queue get bumped down if the limit is decreased. Priority is respected * format * altered test with bigger dicrease, and to test if priority is respected * added endpotint for manually adding members to an event (#730) * added endpotint for manually adding members to an event * format * made migrations * test for registration on wait list if event is full * Feat(qr)/qr generator (#719) * added model for QR code, viewset and serializer * finished create and destroy methods, and mades tests for these * altered create viewset to take user from request * fixed tests * changed status code for deletion of qr code to 200 since frontend dosent accept 204 status code.... * format * removed earlier unused method * format * Trigger Build * changed exception to take all errors with making a blob * format * added azure key to settings file * format * changed name of exception for blbo not found * altered ci.yaml file to add azure connecntion string as env * fix ci file * changed model to take content, and serializer not upload image to azure * format * added users and groups to fixture (#731) * made it possible to add members before and after registration open time (#733) * made it possible to add members before and after registration open time * can add for paid event * format * format * Update CHANGELOG.md * Activity (#736) * first version * changed ordering for activities * filled out categiory enum * fixed test * fixed test again * Update CHANGELOG.md * Added filter for expired and upcoming events (#714) * Added filter for expired and upcoming events * Removed registration filter on event has ended * Added manual filtering for expired events in user viewset * Removed unused import * Started testing expired event method * Finished testing filter methode * format * removed incorrect True comparison * Updated changlog * Added tests where query params give false * Used CaseInsensitiveBooleanQueryParam for handling all types of query params + removed comments * Fixed typo * Formatting --------- Co-authored-by: Harry Linrui XU <[email protected]> Co-authored-by: haruixu <[email protected]> * fixed bug with added order. set the status to SALE. Added 400 status … (#742) fixed bug with added order. set the status to SALE. Added 400 status for adding registration for existing user * fixed issue expired events (#743) * fixed issue expired events * needs a fix * fixed bugs * format * format * fixed filtering * feat(emojis): added emojis (#553) * added emoji dependency * created emoji app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Refactoring of code to be more developer friendly and change some issues
Issue number: closes #
Pull request checklist
Please check if your PR fulfills the following requirements:
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...