Banner filtering #687
Merged
Banner filtering #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomsen85
requested changes
Sep 5, 2023
|
#669 Tihi hadde glemt vi hadde denne |
Like ikke at den var så dymisk. Det var for mye logikk i frontend for å hente ut bannerene. Det eneste man trenger er å se synlige nå, tidligere synlige bannere og fremtidig synlige bannere. Bedre å gjøre den logikken i backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fullfører bannere. Legger til filtrering.
Frontend:
TIHLDE/Kvark#684
Issue number: closes #
Pull request checklist
Please check if your PR fulfills the following requirements:
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...