Fix issue where full error is exposed to external users (#914)

Signed-off-by: Tmpecho <[email protected]>
TIHLDE · Oct 28, 2024 · ef656d3 · ef656d3
1 parent 07a2ab5
commit ef656d3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/app/career/views/weekly_business.py b/app/career/views/weekly_business.py
@@ -12,7 +12,6 @@
 
 
 class WeeklyBusinessViewSet(BaseViewSet):
-
     queryset = WeeklyBusiness.objects.none()
     serializer_class = WeeklyBusinessSerializer
     permission_classes = [BasicViewPermission]
@@ -57,9 +56,10 @@ def create(self, request, *args, **kwargs):
             return Response(
                 {"detail": serializer.errors}, status=status.HTTP_400_BAD_REQUEST
             )
-        except ValueError as value_error:
+        except ValueError:
             return Response(
-                {"detail": str(value_error)}, status=status.HTTP_400_BAD_REQUEST
+                {"detail": "En feil oppstod under behandlingen av forespørselen."},
+                status=status.HTTP_400_BAD_REQUEST
             )
 
     def update(self, request, pk):
@@ -78,9 +78,10 @@ def update(self, request, pk):
             return Response(
                 {"detail": serializer.errors}, status=status.HTTP_400_BAD_REQUEST
             )
-        except ValueError as value_error:
+        except ValueError:
             return Response(
-                {"detail": str(value_error)}, status=status.HTTP_400_BAD_REQUEST
+                {"detail": "En feil oppstod under behandlingen av forespørselen."},
+                status=status.HTTP_400_BAD_REQUEST
             )
 
     def destroy(self, request, *args, **kwargs):

diff --git a/app/content/views/upload.py b/app/content/views/upload.py
@@ -32,11 +32,10 @@ def upload(request):
             {"url": url},
             status=status.HTTP_200_OK,
         )
-
-    except ValueError as value_error:
+    except ValueError:
         return Response(
-            {"detail": str(value_error)},
-            status=status.HTTP_400_BAD_REQUEST,
+            {"detail": "En feil oppstod under behandlingen av forespørselen."},
+            status=status.HTTP_400_BAD_REQUEST
         )
 
 
@@ -54,9 +53,8 @@ def delete(request, container_name, blob_name):
             {"detail": "Filen ble slettet"},
             status=status.HTTP_200_OK,
         )
-
-    except ValueError as value_error:
+    except ValueError:
         return Response(
-            {"detail": str(value_error)},
-            status=status.HTTP_400_BAD_REQUEST,
+            {"detail": "En feil oppstod under behandlingen av forespørselen."},
+            status=status.HTTP_400_BAD_REQUEST
         )