Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Separate XNAT DAG into task groups #27

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

josephmje
Copy link
Contributor

@josephmje josephmje commented Feb 17, 2022

Closes #25.

This PR:

  • Refactors the functionality of datasources_to_xnat.py into the xnat_ingest.py TaskGroup and starts running pytest on this code ec7117a
  • Moves the datman test config files to a more central folder and adds them to a pytest fixture for easy re-use 26760c6 and 8e37126
  • Creates a single DAG in generate_study_dags.py where code from TaskGroups can be imported cf1c42c
  • Adds a DAG integrity test as demonstrated here 9625921

@pep8speaks
Copy link

pep8speaks commented Feb 17, 2022

Hello @josephmje! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 12:1: E302 expected 2 blank lines, found 1
Line 37:80: E501 line too long (80 > 79 characters)

Comment last updated at 2022-03-17 16:08:07 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] - Convert to using factory modules in lieu of a factory method in the DAG file
2 participants