Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet verification #4

Merged
merged 12 commits into from
Aug 16, 2024
Merged

Wallet verification #4

merged 12 commits into from
Aug 16, 2024

Conversation

Jdu278
Copy link
Collaborator

@Jdu278 Jdu278 commented Aug 16, 2024

This pr adds verification for SD-JWT (regular and +ZKP). It also refactors the way we load the Issuer Certs and introduces a new env: ISSUER_CERT. The tests are currently failing because an instantiation of a bean requires the ISSUER_CERT.

Furthermore, it adjusts the way we save the privateKeys from the ZKP challenge to save them in a keyMap, which we then save in RequestObjectRetrieved.

@Jdu278 Jdu278 requested a review from FabioTacke August 16, 2024 11:29
Copy link
Member

@FabioTacke FabioTacke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for now. Thanks!

@Jdu278 Jdu278 merged commit c97c188 into main Aug 16, 2024
2 checks passed
@Jdu278 Jdu278 deleted the wallet-verification branch August 16, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants