Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata and ephemeral key route #2

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Add metadata and ephemeral key route #2

merged 4 commits into from
Aug 9, 2024

Conversation

Jdu278
Copy link
Collaborator

@Jdu278 Jdu278 commented Aug 7, 2024

This pr adds the first two steps of the ZKP library implementation.

  1. It adds additional data to the client_metadata in the presentation_definition .
  2. It adds a new route for the wallet to fetch ephemeral keys necessary for the ZKP.

Furthermore, it adds a new state for saving the presentation to include the privateKeygenerated while calling val (challenge, key) = verifier.createChallenge(challengeRequestData).

@Jdu278 Jdu278 requested a review from FabioTacke August 7, 2024 10:35
Copy link
Member

@FabioTacke FabioTacke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! After adjusting the naming of the public key you can merge the PR right away.

@Jdu278 Jdu278 merged commit 4cfca77 into add-zkp Aug 9, 2024
2 checks passed
@Jdu278 Jdu278 deleted the challenge branch August 9, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants