Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply clang-format #57

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

apply clang-format #57

wants to merge 2 commits into from

Conversation

Thomas-Ulrich
Copy link
Collaborator

@Thomas-Ulrich Thomas-Ulrich commented Sep 28, 2023

apply clang-format on src and app, and add a GitHub workflow to check if the modified code is clang formatted.

@Thomas-Ulrich Thomas-Ulrich mentioned this pull request Sep 28, 2023
@Thomas-Ulrich Thomas-Ulrich changed the base branch from thomas/azure to main June 20, 2024 15:50
@Thomas-Ulrich Thomas-Ulrich force-pushed the thomas/apply_clang-format branch 2 times, most recently from cd5ce9d to 1eb0e1f Compare June 20, 2024 16:16
@Thomas-Ulrich Thomas-Ulrich mentioned this pull request Oct 25, 2024
@hpc4geo
Copy link
Collaborator

hpc4geo commented Nov 6, 2024

@Thomas-Ulrich This PR contains some non-mergable content. It appears your ci/workflow changes were applied after git submodule update --init was invoked. Hence the clang-formatting rules have been applied to yateto source, and now the yateto code wooers as new additions to the tandem repo.

Can you please resolve this?

What would be good is you only include the change sets for

format.sh
clang-format.yml

in this PR.

Then afterwards we can go and clean up the source tree applying the formatting rules.

@Thomas-Ulrich Thomas-Ulrich force-pushed the thomas/apply_clang-format branch 2 times, most recently from 875eda6 to 65fa69e Compare November 6, 2024 13:27
@Thomas-Ulrich
Copy link
Collaborator Author

Thomas-Ulrich commented Nov 6, 2024

Right, I did add the updated yateto by mistake in the PR.
I now have 2 commits:
the first one: add the worfklow files.
The second one applying clang-format with:

pip3 install clang-format==19.1.3
.ci/format.sh $(which clang-format) .
git add -u
git commit -m "apply clang-format"

If you prefer you can cherrypick the first commit and run the 2nd command.

(note that I update clang-format to 19 instead of 18 (because it was giving roughly the same number of modified lines ~3000, so let's use a more recent version I thought).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants