-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#12596 ] Instructor extending individual deadlines: table doesn't sort by team… #12707
Closed
suneelval
wants to merge
42
commits into
TEAMMATES:master
from
suneelval:Instructor_extending_table_sort_by_team_issue
Closed
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
3187a20
Instructor extending individual deadlines: table doesn't sort by team…
suneelval 959ed75
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval 1e7e6a2
ETETest case build failure issue fix
suneelval 646f1d6
ETETest case build failure issue fix
suneelval b883dc0
ETETest case build failure issue fix
suneelval 1ac968a
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval 77cd4c9
Update InstructorSessionIndividualExtensionPageE2ETest.java
suneelval 74ba497
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval 2f59cbc
Revert "Update InstructorSessionIndividualExtensionPageE2ETest.java"
suneelval 3d1b3e4
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval 1ce977f
Update InstructorSessionIndividualExtensionPageE2ETest.java
suneelval 78a3ba4
Revert "Update InstructorSessionIndividualExtensionPageE2ETest.java"
suneelval 45be882
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval c5fe20b
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval 28c3364
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval fe80153
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval 63cf4d2
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval 0b3383e
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval bad806b
Update InstructorSessionIndividualExtensionPageE2ETest.java
suneelval 8f0c64d
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval 2958f18
Update InstructorSessionIndividualExtensionPageE2ETest.java
suneelval 7f656f6
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval c14acdd
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval aaa6505
removed unnecessary mock data
suneelval 7781d2e
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval 0d2b9a8
Merge branch 'master' into Instructor_extending_table_sort_by_team_issue
suneelval 266e599
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval d456b5c
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval 042fb92
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval eba76ea
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval 3e089b6
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval 919e5b7
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval 9452a96
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval 6c50da8
Merge branch 'master' into Instructor_extending_table_sort_by_team_issue
mingyuanc b20fdfd
Merge branch 'Instructor_extending_table_sort_by_team_issue' of https…
suneelval 8ef6628
Update InstructorStudentActivityLogsPageE2ETest.json
suneelval 8f26be2
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval d81b900
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval 0fbb9cc
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval feebdd3
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval 4e6a651
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval 8eafa85
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,7 @@ public class InstructorSessionIndividualExtensionPageE2ETest extends BaseE2ETest | |
protected void prepareTestData() { | ||
testData = loadDataBundle("/InstructorSessionIndividualExtensionPageE2ETest.json"); | ||
testEmail = TestProperties.TEST_EMAIL; | ||
testData.students.get("[email protected]").setEmail(testEmail); | ||
removeAndRestoreDataBundle(testData); | ||
instructor = testData.instructors.get("ISesIe.instructor1"); | ||
course = testData.courses.get("course"); | ||
feedbackSession = testData.feedbackSessions.get("firstSession"); | ||
|
@@ -58,7 +58,7 @@ public void testAll() { | |
|
||
______TS("verify extend some deadlines, notifyUsers enabled"); | ||
|
||
individualExtensionPage.selectStudents(0, 2); // alice and charlie | ||
individualExtensionPage.selectStudents(0, 1); // alice and charlie | ||
individualExtensionPage.selectInstructor(0); // instructor 1 | ||
|
||
individualExtensionPage.extendDeadlineByTwelveHours(true); | ||
|
@@ -69,7 +69,7 @@ public void testAll() { | |
Map<String, Instant> updatedInstructorDeadlines = updatedSession.getInstructorDeadlines(); | ||
Instant expectedDeadline = feedbackSession.getEndTime().plus(Duration.ofHours(12)); | ||
|
||
verifyUpdatedDeadlinesMap(updatedStudentDeadlines, TestProperties.TEST_EMAIL, "[email protected]"); | ||
verifyUpdatedDeadlinesMap(updatedStudentDeadlines, testEmail, "[email protected]"); | ||
verifyUpdatedDeadlinesMap(updatedInstructorDeadlines, "[email protected]"); | ||
verifyDeadlineExtensionsPresentOrAbsent(updatedStudentDeadlines, updatedInstructorDeadlines, expectedDeadline); | ||
|
||
|
@@ -92,7 +92,7 @@ public void testAll() { | |
updatedStudentDeadlines = updatedSession.getStudentDeadlines(); | ||
updatedInstructorDeadlines = updatedSession.getInstructorDeadlines(); | ||
|
||
verifyUpdatedDeadlinesMap(updatedStudentDeadlines, TestProperties.TEST_EMAIL, "[email protected]"); | ||
verifyUpdatedDeadlinesMap(updatedStudentDeadlines, testEmail, "[email protected]"); | ||
verifyUpdatedDeadlinesMap(updatedInstructorDeadlines, "[email protected]"); | ||
verifyDeadlineExtensionsPresentOrAbsent(updatedStudentDeadlines, updatedInstructorDeadlines, expectedDeadline); | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,8 +122,39 @@ | |
"isOpeningEmailEnabled": true, | ||
"isClosingEmailEnabled": true, | ||
"isPublishedEmailEnabled": true, | ||
"studentDeadlines": {}, | ||
"instructorDeadlines": {} | ||
"studentDeadlines": { | ||
"[email protected]": "2032-04-30T17:00:00Z", | ||
"[email protected]": "2032-04-30T17:00:00Z" | ||
}, | ||
"instructorDeadlines": { | ||
"[email protected]": "2032-04-30T17:00:00Z" | ||
} | ||
}, | ||
"openSession": { | ||
"feedbackSessionName": "Open Session", | ||
"courseId": "tm.e2e.ISesIe.CS2104", | ||
"creatorEmail": "[email protected]", | ||
"instructions": "<p>Instructions for Open Session</p>", | ||
"createdTime": "2012-04-01T23:59:00Z", | ||
"startTime": "2012-04-01T22:00:00Z", | ||
"endTime": "2032-04-30T16:00:00Z", | ||
"sessionVisibleFromTime": "2012-04-01T22:00:00Z", | ||
"resultsVisibleFromTime": "2032-05-01T22:00:00Z", | ||
"timeZone": "Asia/Singapore", | ||
"gracePeriod": 10, | ||
"sentOpenEmail": false, | ||
"sentClosingEmail": false, | ||
"sentClosedEmail": false, | ||
"sentPublishedEmail": false, | ||
"isOpeningEmailEnabled": true, | ||
"isClosingEmailEnabled": true, | ||
"isPublishedEmailEnabled": true, | ||
"studentDeadlines": { | ||
"[email protected]": "2032-04-30T17:00:00Z" | ||
}, | ||
"instructorDeadlines": { | ||
"[email protected]": "2032-04-30T17:00:00Z" | ||
} | ||
} | ||
}, | ||
"feedbackQuestions": { | ||
|
@@ -160,7 +191,7 @@ | |
}, | ||
"qn2": { | ||
"feedbackSessionName": "First Session", | ||
"courseId": "tm.e2e.FRes.CS2104", | ||
"courseId": "tm.e2e.ISesIe.CS2104", | ||
"questionDetails": { | ||
"questionType": "TEXT", | ||
"questionText": "First instructor question" | ||
|
@@ -198,5 +229,38 @@ | |
} | ||
} | ||
}, | ||
"feedbackResponseComments": {} | ||
"feedbackResponseComments": {}, | ||
"notifications": {}, | ||
"deadlineExtensions": { | ||
"student1InCourse1Session1": { | ||
"courseId": "tm.e2e.ISesIe.CS2104", | ||
"feedbackSessionName": "First Session", | ||
"userEmail": "[email protected]", | ||
"isInstructor": false, | ||
"endTime": "2032-05-01T05:00:00Z", | ||
"sentClosingEmail": false, | ||
"createdAt": "2032-05-01T01:00:00Z", | ||
"updatedAt": "2032-05-01T01:00:00Z" | ||
}, | ||
"student2InCourse1Session1": { | ||
"courseId": "tm.e2e.ISesIe.CS2104", | ||
"feedbackSessionName": "First Session", | ||
"userEmail": "[email protected]", | ||
"isInstructor": false, | ||
"endTime": "2032-05-01T05:00:00Z", | ||
"sentClosingEmail": false, | ||
"createdAt": "2032-05-01T01:00:00Z", | ||
"updatedAt": "2032-05-01T01:00:00Z" | ||
}, | ||
"instructor1InCourse1Session1": { | ||
"courseId": "tm.e2e.ISesIe.CS2104", | ||
"feedbackSessionName": "First Session", | ||
"userEmail": "[email protected]", | ||
"isInstructor": true, | ||
"endTime": "2032-05-01T05:00:00Z", | ||
"sentClosingEmail": false, | ||
"createdAt": "2032-05-01T01:00:00Z", | ||
"updatedAt": "2032-05-01T01:00:00Z" | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,7 +43,7 @@ | |
"students": { | ||
"[email protected]": { | ||
"googleId": "tm.e2e.ISActLogs.alice.tmms", | ||
"email": "alice.b.[email protected]", | ||
"email": "[email protected]", | ||
"course": "tm.e2e.ISActLogs.CS2104", | ||
"name": "Alice Betsy", | ||
"comments": "This student's name is Alice Betsy", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for missing this out but any reason u changed this to 1?