Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12596 ] Instructor extending individual deadlines: table doesn't sort by team… #12707

Closed
wants to merge 42 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
3187a20
Instructor extending individual deadlines: table doesn't sort by team…
suneelval Jan 26, 2024
959ed75
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Jan 26, 2024
1e7e6a2
ETETest case build failure issue fix
suneelval Jan 29, 2024
646f1d6
ETETest case build failure issue fix
suneelval Jan 29, 2024
b883dc0
ETETest case build failure issue fix
suneelval Jan 29, 2024
1ac968a
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jan 29, 2024
77cd4c9
Update InstructorSessionIndividualExtensionPageE2ETest.java
suneelval Jan 29, 2024
74ba497
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jan 29, 2024
2f59cbc
Revert "Update InstructorSessionIndividualExtensionPageE2ETest.java"
suneelval Jan 29, 2024
3d1b3e4
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jan 29, 2024
1ce977f
Update InstructorSessionIndividualExtensionPageE2ETest.java
suneelval Jan 29, 2024
78a3ba4
Revert "Update InstructorSessionIndividualExtensionPageE2ETest.java"
suneelval Jan 29, 2024
45be882
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jan 29, 2024
c5fe20b
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jan 29, 2024
28c3364
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jan 29, 2024
fe80153
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jan 29, 2024
63cf4d2
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jan 29, 2024
0b3383e
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jan 29, 2024
bad806b
Update InstructorSessionIndividualExtensionPageE2ETest.java
suneelval Jan 30, 2024
8f0c64d
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jan 30, 2024
2958f18
Update InstructorSessionIndividualExtensionPageE2ETest.java
suneelval Jan 30, 2024
7f656f6
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jan 30, 2024
c14acdd
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Feb 25, 2024
aaa6505
removed unnecessary mock data
suneelval Feb 25, 2024
7781d2e
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Feb 26, 2024
0d2b9a8
Merge branch 'master' into Instructor_extending_table_sort_by_team_issue
suneelval Feb 27, 2024
266e599
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Mar 22, 2024
d456b5c
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Mar 23, 2024
042fb92
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Mar 26, 2024
eba76ea
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Mar 26, 2024
3e089b6
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Mar 27, 2024
919e5b7
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Mar 28, 2024
9452a96
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Jun 11, 2024
6c50da8
Merge branch 'master' into Instructor_extending_table_sort_by_team_issue
mingyuanc Jun 20, 2024
b20fdfd
Merge branch 'Instructor_extending_table_sort_by_team_issue' of https…
suneelval Jun 20, 2024
8ef6628
Update InstructorStudentActivityLogsPageE2ETest.json
suneelval Jun 20, 2024
8f26be2
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Jun 24, 2024
d81b900
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Jun 30, 2024
0fbb9cc
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Jul 1, 2024
feebdd3
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Jul 8, 2024
4e6a651
Update InstructorSessionIndividualExtensionPageE2ETest.json
suneelval Jul 8, 2024
8eafa85
Merge branch 'TEAMMATES:master' into Instructor_extending_table_sort_…
suneelval Jul 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public class InstructorSessionIndividualExtensionPageE2ETest extends BaseE2ETest
protected void prepareTestData() {
testData = loadDataBundle("/InstructorSessionIndividualExtensionPageE2ETest.json");
testEmail = TestProperties.TEST_EMAIL;
testData.students.get("[email protected]").setEmail(testEmail);
removeAndRestoreDataBundle(testData);
instructor = testData.instructors.get("ISesIe.instructor1");
course = testData.courses.get("course");
feedbackSession = testData.feedbackSessions.get("firstSession");
Expand All @@ -58,7 +58,7 @@ public void testAll() {

______TS("verify extend some deadlines, notifyUsers enabled");

individualExtensionPage.selectStudents(0, 2); // alice and charlie
individualExtensionPage.selectStudents(0, 1); // alice and charlie
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this out but any reason u changed this to 1?

individualExtensionPage.selectInstructor(0); // instructor 1

individualExtensionPage.extendDeadlineByTwelveHours(true);
Expand All @@ -69,7 +69,7 @@ public void testAll() {
Map<String, Instant> updatedInstructorDeadlines = updatedSession.getInstructorDeadlines();
Instant expectedDeadline = feedbackSession.getEndTime().plus(Duration.ofHours(12));

verifyUpdatedDeadlinesMap(updatedStudentDeadlines, TestProperties.TEST_EMAIL, "[email protected]");
verifyUpdatedDeadlinesMap(updatedStudentDeadlines, testEmail, "[email protected]");
verifyUpdatedDeadlinesMap(updatedInstructorDeadlines, "[email protected]");
verifyDeadlineExtensionsPresentOrAbsent(updatedStudentDeadlines, updatedInstructorDeadlines, expectedDeadline);

Expand All @@ -92,7 +92,7 @@ public void testAll() {
updatedStudentDeadlines = updatedSession.getStudentDeadlines();
updatedInstructorDeadlines = updatedSession.getInstructorDeadlines();

verifyUpdatedDeadlinesMap(updatedStudentDeadlines, TestProperties.TEST_EMAIL, "[email protected]");
verifyUpdatedDeadlinesMap(updatedStudentDeadlines, testEmail, "[email protected]");
verifyUpdatedDeadlinesMap(updatedInstructorDeadlines, "[email protected]");
verifyDeadlineExtensionsPresentOrAbsent(updatedStudentDeadlines, updatedInstructorDeadlines, expectedDeadline);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,39 @@
"isOpeningEmailEnabled": true,
"isClosingEmailEnabled": true,
"isPublishedEmailEnabled": true,
"studentDeadlines": {},
"instructorDeadlines": {}
"studentDeadlines": {
"[email protected]": "2032-04-30T17:00:00Z",
"[email protected]": "2032-04-30T17:00:00Z"
},
"instructorDeadlines": {
"[email protected]": "2032-04-30T17:00:00Z"
}
},
"openSession": {
"feedbackSessionName": "Open Session",
"courseId": "tm.e2e.ISesIe.CS2104",
"creatorEmail": "[email protected]",
"instructions": "<p>Instructions for Open Session</p>",
"createdTime": "2012-04-01T23:59:00Z",
"startTime": "2012-04-01T22:00:00Z",
"endTime": "2032-04-30T16:00:00Z",
"sessionVisibleFromTime": "2012-04-01T22:00:00Z",
"resultsVisibleFromTime": "2032-05-01T22:00:00Z",
"timeZone": "Asia/Singapore",
"gracePeriod": 10,
"sentOpenEmail": false,
"sentClosingEmail": false,
"sentClosedEmail": false,
"sentPublishedEmail": false,
"isOpeningEmailEnabled": true,
"isClosingEmailEnabled": true,
"isPublishedEmailEnabled": true,
"studentDeadlines": {
"[email protected]": "2032-04-30T17:00:00Z"
},
"instructorDeadlines": {
"[email protected]": "2032-04-30T17:00:00Z"
}
}
},
"feedbackQuestions": {
Expand Down Expand Up @@ -160,7 +191,7 @@
},
"qn2": {
"feedbackSessionName": "First Session",
"courseId": "tm.e2e.FRes.CS2104",
"courseId": "tm.e2e.ISesIe.CS2104",
"questionDetails": {
"questionType": "TEXT",
"questionText": "First instructor question"
Expand Down Expand Up @@ -198,5 +229,38 @@
}
}
},
"feedbackResponseComments": {}
"feedbackResponseComments": {},
"notifications": {},
"deadlineExtensions": {
"student1InCourse1Session1": {
"courseId": "tm.e2e.ISesIe.CS2104",
"feedbackSessionName": "First Session",
"userEmail": "[email protected]",
"isInstructor": false,
"endTime": "2032-05-01T05:00:00Z",
"sentClosingEmail": false,
"createdAt": "2032-05-01T01:00:00Z",
"updatedAt": "2032-05-01T01:00:00Z"
},
"student2InCourse1Session1": {
"courseId": "tm.e2e.ISesIe.CS2104",
"feedbackSessionName": "First Session",
"userEmail": "[email protected]",
"isInstructor": false,
"endTime": "2032-05-01T05:00:00Z",
"sentClosingEmail": false,
"createdAt": "2032-05-01T01:00:00Z",
"updatedAt": "2032-05-01T01:00:00Z"
},
"instructor1InCourse1Session1": {
"courseId": "tm.e2e.ISesIe.CS2104",
"feedbackSessionName": "First Session",
"userEmail": "[email protected]",
"isInstructor": true,
"endTime": "2032-05-01T05:00:00Z",
"sentClosingEmail": false,
"createdAt": "2032-05-01T01:00:00Z",
"updatedAt": "2032-05-01T01:00:00Z"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"students": {
"[email protected]": {
"googleId": "tm.e2e.ISActLogs.alice.tmms",
"email": "alice.b.[email protected]",
"email": "[email protected]",
"course": "tm.e2e.ISActLogs.CS2104",
"name": "Alice Betsy",
"comments": "This student's name is Alice Betsy",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -531,8 +531,8 @@ export class InstructorSessionIndividualExtensionPageComponent implements OnInit
strB = b.sectionName;
break;
case SortBy.TEAM_NAME:
strA = a.sectionName;
strB = b.sectionName;
strA = a.teamName;
strB = b.teamName;
break;
case SortBy.RESPONDENT_NAME:
strA = a.name;
Expand Down
Loading