-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ Fix ] 온보딩 완료 후 이탈한 선배 대비 SENIOR_PENDING 추가 반영 #357
Open
se0jinYoon
wants to merge
9
commits into
develop
Choose a base branch
from
fix/#350/seniorPendingRole
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0d83653
fix: senior 온보딩의 경우 role SENIOR_PENDING 으로 수정
se0jinYoon 234aa59
fix: 온보딩 중 이탈한 선배 접속시 라우팅 반영
se0jinYoon f6e8896
fix: 선배 회원가입 접근시 최초 role SENIOR_PENDING으로 수정
se0jinYoon 51fc154
chore: 주석 추가, 최초 가입시 SENIOR_PENDING
se0jinYoon 0e7adf5
fix: Layout에 SENIOR_PENDING으로 변경
se0jinYoon e61f1e5
fix: 변수명 변경, 필요없는 seniorId제거, nickname outletContextData 이용하여 받아오기로 변경
se0jinYoon ac9abb6
chore: 변경된 api 반영 userType -> role
se0jinYoon 3b52a73
fix: 선배 카드 조회 - 후배약속신청 뷰일 경우에만 선배 데이터 조회 쿼리 동작하도록 로직 변경
se0jinYoon d6666d7
fix: 온보딩 완료 후 SeniorId 받아와서 프로필 등록시 온보딩 정보 불러오기
se0jinYoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
import { getSeniorProfileAxios } from "@pages/seniorProfile/apis/getSeniorProfileAxios"; | ||
import { SeniorProfileAPIResType } from "@pages/seniorProfile/types"; | ||
import { useQuery } from "@tanstack/react-query"; | ||
import { getSeniorProfileAxios } from '@pages/seniorProfile/apis/getSeniorProfileAxios'; | ||
import { SeniorProfileAPIResType } from '@pages/seniorProfile/types'; | ||
import { useQuery } from '@tanstack/react-query'; | ||
|
||
export const useGetSeniorProfileQuery = (seniorId: string) => { | ||
export const useGetSeniorProfileQuery = (seniorId: string, isJuniorRequest: boolean) => { | ||
return useQuery<SeniorProfileAPIResType, Error>({ | ||
queryKey: ['seniorProfile', seniorId], | ||
queryFn: () => getSeniorProfileAxios(seniorId).then(response => response.data.data), | ||
}) | ||
queryFn: () => getSeniorProfileAxios(seniorId).then((response) => response.data.data), | ||
enabled: !!isJuniorRequest, | ||
}); | ||
}; | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3) localStorage removeItem 함수도 utils storage에 함께 분리시켜주면 좋을 것 같아요/!