#90 [feat] 모델 지원서 상세보기 기능 구현 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KWY0218
reviewed
Jan 11, 2024
| @@ -5,7 +5,8 @@ | |||
| @Getter | |||
| @AllArgsConstructor | |||
| public enum ServiceRecordTerm { | |||
| UNDER_ONE("1 개월 미만"), ONE_THREE("1 - 3 개월"), FOUR_SIX("4 - 6 개월"), SEVEN_TWELVE("7 - 12 개월"), ABOVE_TWELVE("12 개월 초과"); | |||
| UNDER_ONE("1 개월 미만",1), ONE_THREE("1 - 3 개월",2), FOUR_SIX("4 - 6 개월",3), SEVEN_TWELVE("7 - 12 개월", 4), ABOVE_TWELVE("12 개월 초과", 5); | |||
There was a problem hiding this comment.
p2
enum class의 기본 속성 중 ordinal 이란 속성이 있습니다.
sort를 위해 order를 추가한 듯 보이는데, ordinal을 사용하면 order을 제거할 수 있을 것 같습니다!
hellozo0
approved these changes
Jan 11, 2024
| @Operation(summary = "[JWT] 모델 지원서 상세 조회", description = "모델 지원서 상세 조회 API입니다.") | ||
| @ApiResponses({ | ||
| @ApiResponse(responseCode = "200", description = "모델 지원서 상세 조회 성공", content = @Content(schema = @Schema(implementation = ApplicationDetailInfoResponse.class))), | ||
| @ApiResponse(responseCode = "401", description = "인증 오류 입니다.", content = @Content(schema = @Schema(implementation = ErrorResponse.class))), |
There was a problem hiding this comment.
p3:
여기에 applicationId가 잘못왔을 때에 대한 404 에러도 있어야할것 같아요
added 2 commits
January 11, 2024 23:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈번호
해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?