#264 [feat]지원서 상세보기 applicationInfo 에 등록일, 만료일 추가 #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkl0912
changed the title
KWY0218
reviewed
Feb 29, 2024
Comment on lines
101
to
102
| hairModelApplication.getCreateDate().format(DateTimeFormatter.ofPattern("yyyy. MM. dd.")), | ||
| hairModelApplication.getExpireDate().format(DateTimeFormatter.ofPattern("yyyy. MM. dd."))); |
There was a problem hiding this comment.
p2
"yyyy. MM. dd." 이 부분을 상수로 만들어서 재사용한다면, 이후 형식이 바뀌었을 때 수정하기 더 용이해질 것 같습니다!
Comment on lines
52
to
58
| public LocalDate getCreateDate(){ | ||
| LocalDate createDate = getCreatedAt().toLocalDate(); | ||
| return createDate; | ||
| } | ||
| public LocalDate getExpireDate(){ | ||
| LocalDate expiredDate = getCreatedAt().plusDays(7).toLocalDate(); | ||
| return expiredDate; |
There was a problem hiding this comment.
p4
함수명 과 변수명에 ed 를 붙이면 좋을 것 같습니다..!
KWY0218
reviewed
Mar 1, 2024
| @@ -43,6 +42,7 @@ public class HairModelApplicationRetrieveService { | |||
| private final S3Service s3Service; | |||
| private final PreferHairStyleJpaRepository preferHairStyleJpaRepository; | |||
| private final HairServiceRecordJpaRepository hairServiceRecordJpaRepository; | |||
| private final String dateFormat = "yyyy. MM. dd."; | |||
There was a problem hiding this comment.
p2
보통 자바에서 상수를 만들 때는 UPPER_SNAKE_CASE 형식을 자주 사용하며
private final이 아닌 private static final 을 통해 정의하곤 합니다.
수정을 하면서 final과 static final 에 대해서 알아보면 좋을 것 같습니다!
KWY0218
approved these changes
Mar 2, 2024
Comment on lines
15
to
17
| String createDate, | ||
| String expireDate | ||
| ) { |
There was a problem hiding this comment.
p3
해당 속성 명도 ed를 붙인 뒤, 노션 api 도 수정하면 좋을 거 같습니다..!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈번호
해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?
applicationInfo 객체 끝에 createDate, expireDate 추가했습니다