#260 [feat] 지원서 작성하기 POST API에 response로 만료일 보내기 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KWY0218
reviewed
Feb 28, 2024
Comment on lines
53
to
56
| public String calExpireDate(){ | ||
| LocalDate expiredDate = getCreatedAt().plusDays(7).toLocalDate(); | ||
| return expiredDate.format(DateTimeFormatter.ofPattern("yyyy. MM. dd.")); | ||
| } |
There was a problem hiding this comment.
p3
해당 도메인에서는 만료일만 반환하고 format을 맞추는 작업은 service 내에서 하는 것이 어떨까요?
해당 날짜 포멧은 api에 의해 실행되서 동작하는 로직인데, 도메인 로직에서 해당 로직을 실행하는 것은 다소 어색하다고 생각합니다..!
또한, 만약 다른 api에서 다른 날짜 포멧으로 반환해야 할 때, 해당 도메인 로직이 수정되는 사항이 발생하기 때문에 해당 도메인 로직에서는 만료일 값만 반환하고, 서비스 로직에서 처리하는 것이 좋을 것 같습니다
p3
또한, 결국 만료일을 반환 받는 것이기 때문에 getExpiredDate 의 네이밍이 더 자연스러울 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈번호
해결하는 데 얼마나 걸렸나요? (예상 작업 시간 / 실제 작업 시간)
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?