Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 날짜 인풋 유효성 검사 #99

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

wrryu09
Copy link
Member

@wrryu09 wrryu09 commented Jul 11, 2024

작업 내용 🧑‍💻

  • 날짜 인풋 유효성 검사 유틸 함수를 만들었습니다
  • 그리고 TextboxInput에 추가했습니다.

알게된 점 🚀

기록하며 개발하기!

day <= 31 조건을 명시적으로 추가하지 않아도 new Date(year, month, 0).getDate()가 해당 월의 최대 일수를 반환해서 이 조건이 없어도 32일이나 31일이 없는 달의 31일이 잘 걸러짐!
그래도 명시적으로 조건을 표시해두긴 하였습니다.

리뷰 요구사항 💬

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

이상한 값 넣었을 때 잘 막아지는지 확인해주시면 감사하겠습니당

관련 이슈

close #97

스크린샷 (선택)

image image

@wrryu09 wrryu09 self-assigned this Jul 11, 2024
@wrryu09 wrryu09 linked an issue Jul 11, 2024 that may be closed by this pull request
Copy link
Contributor

@Kjiw0n Kjiw0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~ 굳굳짱짱

Copy link
Member

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2000년에서 9999년이면 까지 월, 일도 잘 처리를 해주셨군요 수고하셨습니당 👍 LGTM

@seong-hui seong-hui merged commit f5c18d7 into develop Jul 11, 2024
2 checks passed
@seong-hui seong-hui deleted the feat/#97/date-input-check branch July 11, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEAT] 날짜 인풋 유효성 검사
3 participants