-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] 공통 모달 퍼블리싱 수정 #75
Changes from 12 commits
cb9b586
00575a8
d09727b
7c6a5e7
9d498e1
89727c9
0e88253
5fb3de1
42be021
0986c29
410c275
f660f3b
e4e254b
6b995bc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 헉 진짜 깔끔하다 👍 👍 굳굳 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import styled from '@emotion/styled'; | ||
import { FunctionComponent, SVGProps } from 'react'; | ||
|
||
import Icons from '@/assets/svg/index'; | ||
import { SettingLayout, smallIcon, bigIcon } from '@/components/common/button/settingBtn/settingBtnStyle'; | ||
|
||
const settingIconMap: Record<string, FunctionComponent<SVGProps<SVGSVGElement>>> = { | ||
complete: Icons.SettingIcons.SettingCheck1, | ||
check: Icons.SettingIcons.SettingCheck2, | ||
done: Icons.SettingIcons.SettingCheck3, | ||
progress: Icons.SettingIcons.SettingCheck4, | ||
xBtn: Icons.SettingX, | ||
}; | ||
interface SettingCheckBtnProps { | ||
size: 'small' | 'big'; | ||
type: 'complete' | 'check' | 'done' | 'progress' | 'xBtn'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 동일한 스타일 속성을 가진 버튼들을 하나로 합쳐서 type으로 아이콘만 변경해주었군요! 다 다른 svg 파일을 가져오기 어려울 것 같아 여러 파일들로 뺐는데 이렇게 하니 훨신 편할 것 같네요,, 정말 고생 많으셨습니다.. 👍 |
||
onClick?: () => void; | ||
isHover: boolean; | ||
isPressed: boolean; | ||
isActive: boolean; | ||
} | ||
|
||
function SettingCheckBtn({ size, type, onClick, isHover, isPressed, isActive }: SettingCheckBtnProps) { | ||
const IconComponent = settingIconMap[type]; | ||
|
||
const isFill = type === 'progress'; | ||
|
||
const StyledSettingCheckIcon = styled(IconComponent)<{ size: string }>` | ||
${({ size }) => (size === 'small' ? smallIcon : bigIcon)}; | ||
Comment on lines
+24
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 아이콘 맵 함수로 빼는 법 배우고 갑니다 ㅎㅎ 굿굿 |
||
`; | ||
|
||
return ( | ||
<SettingLayout | ||
size={size} | ||
isFill={isFill} | ||
onClick={onClick} | ||
isHover={isHover} | ||
isPressed={isPressed} | ||
isActive={isActive} | ||
> | ||
<StyledSettingCheckIcon size={size} /> | ||
</SettingLayout> | ||
); | ||
} | ||
|
||
export default SettingCheckBtn; |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
으앙,,, 제가 처음으로 퍼블리싱한 쪽이라 많이 미숙했나봅니다 초반엔,, 말씀 하시지 잉잉 ㅜ 감사합니다,,,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아잇 아닙니다 넘 잘한다 우리 지민이 💜