-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] 공통 모달 퍼블리싱 수정 #75
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
cb9b586
fix: 다른 요소 컴포넌트 가져와서 모달 배치 완료
seong-hui 00575a8
fix: OkayCancelBtn hover 효과 추가
seong-hui d09727b
fix: setting 버튼 공통
seong-hui 7c6a5e7
fix: progress 버튼은 active시 fill이 채워지도록 하는 로직 추가
seong-hui 9d498e1
fix: svg 패딩없는 버전으로 변경
seong-hui 89727c9
feat: 세팅 버튼 props에 hover, active 요소 추가
seong-hui 0e88253
fix: status button check1btn 지우고 공통 세팅 버튼으로 수정
seong-hui 5fb3de1
fix: 버튼 모달 이미지 변경
seong-hui 42be021
settingCheck4 버튼 삭제
seong-hui 0986c29
style: emotion 이름 수정
seong-hui 410c275
fix: SettingLayout 에 css추가
seong-hui f660f3b
Merge branch 'develop' into fix/#65/fix-modal
seong-hui e4e254b
delete: settingX 버튼 삭제하고 settingCheckBtn으로 통합:
seong-hui 6b995bc
fix: xBtn 이름 close로 변경
seong-hui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import styled from '@emotion/styled'; | ||
|
||
function CategoryBox() { | ||
return ( | ||
<CategoryBoxLayout> | ||
<TitleSection>카테고리</TitleSection> | ||
</CategoryBoxLayout> | ||
); | ||
} | ||
|
||
const CategoryBoxLayout = styled.div` | ||
width: 31.7rem; | ||
height: 49rem; | ||
|
||
border: 1px solid #e4e4e4; | ||
border-radius: 12px; | ||
`; | ||
|
||
const TitleSection = styled.section` | ||
width: 100%; | ||
height: 6.6rem; | ||
padding: 2rem 0.8rem 1.8rem 2.8rem; | ||
|
||
${({ theme }) => theme.fontTheme.HEADLINE_02} | ||
`; | ||
export default CategoryBox; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 0 additions & 19 deletions
19
src/components/common/button/settingBtn/SettingCheck2Btn.tsx
This file was deleted.
Oops, something went wrong.
19 changes: 0 additions & 19 deletions
19
src/components/common/button/settingBtn/SettingCheck3Btn.tsx
This file was deleted.
Oops, something went wrong.
52 changes: 0 additions & 52 deletions
52
src/components/common/button/settingBtn/SettingCheck4Btn.tsx
This file was deleted.
Oops, something went wrong.
46 changes: 46 additions & 0 deletions
46
src/components/common/button/settingBtn/SettingCheckBtn.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
import styled from '@emotion/styled'; | ||
import { FunctionComponent, SVGProps } from 'react'; | ||
|
||
import Icons from '@/assets/svg/index'; | ||
import { SettingLayout, smallIcon, bigIcon } from '@/components/common/button/settingBtn/settingBtnStyle'; | ||
|
||
const settingIconMap: Record<string, FunctionComponent<SVGProps<SVGSVGElement>>> = { | ||
complete: Icons.SettingIcons.SettingCheck1, | ||
check: Icons.SettingIcons.SettingCheck2, | ||
done: Icons.SettingIcons.SettingCheck3, | ||
progress: Icons.SettingIcons.SettingCheck4, | ||
close: Icons.SettingX, | ||
}; | ||
interface SettingCheckBtnProps { | ||
size: 'small' | 'big'; | ||
type: 'complete' | 'check' | 'done' | 'progress' | 'close'; | ||
onClick?: () => void; | ||
isHover: boolean; | ||
isPressed: boolean; | ||
isActive: boolean; | ||
} | ||
|
||
function SettingCheckBtn({ size, type, onClick, isHover, isPressed, isActive }: SettingCheckBtnProps) { | ||
const IconComponent = settingIconMap[type]; | ||
|
||
const isFill = type === 'progress'; | ||
|
||
const StyledSettingCheckIcon = styled(IconComponent)<{ size: string }>` | ||
${({ size }) => (size === 'small' ? smallIcon : bigIcon)}; | ||
Comment on lines
+24
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 아이콘 맵 함수로 빼는 법 배우고 갑니다 ㅎㅎ 굿굿 |
||
`; | ||
|
||
return ( | ||
<SettingLayout | ||
size={size} | ||
isFill={isFill} | ||
onClick={onClick} | ||
isHover={isHover} | ||
isPressed={isPressed} | ||
isActive={isActive} | ||
> | ||
<StyledSettingCheckIcon size={size} /> | ||
</SettingLayout> | ||
); | ||
} | ||
|
||
export default SettingCheckBtn; |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉 진짜 깔끔하다 👍 👍 굳굳