[FEAT] Arrange 버튼 퍼블리싱 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
seong-hui
approved these changes
Jul 8, 2024
| }; | ||
| function ArrangeBtn({ type, mode, color, size }: ArrangeBtnType) { | ||
| const IconComponent = iconMap[type]; | ||
| const StyledIcon = styled(IconComponent)<{ size: string; color: string; mode: string }>` |
There was a problem hiding this comment.
iconMap[type]을 선언하고 타입에 대한 스타일을 만들어서 내보내는 방식 굉장히 좋은 것 같아요 배워갑니당
| @@ -0,0 +1,10 @@ | |||
| import { css } from '@emotion/react'; | |||
|
|
|||
| export const smallSize = css` | |||
| @@ -0,0 +1,6 @@ | |||
| export interface ArrangeBtnType { | |||
| type: 'right' | 'left' | 'set' | 'calendar'; | |||
| mode: 'DISABLED' | 'DEFAULT'; | |||
There was a problem hiding this comment.
light라는 색상도 추가돼서 mode에 light도 넣으면 좋을 것 같아요!
There was a problem hiding this comment.
ArrangeBtn 들에는 LIGHT 가 없기도 하고 LIGHT 있는 쪽 버튼들 DEFAULT 가 다르게 사용된다고 해서 ... 다른 버튼에는 타입 새로 만들어야 할 것 같습니다!
jeeminyi
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 🧑💻
버튼을 만들었습니다.
알게된 점 🚀
svg 색상 바꾸기
currentColor로만 바꿔왔었는데 지원언니가 알려준대로 path{} rect{} 등으로 하니까 적용 잘 되네요!! 배워갑니당!!리뷰 요구사항 💬
disabled 상태에서도 호버랑 pressed 허용할건지?
컴포넌트 하나로 끝장내고 싶어서 이렇게 제작했는데 props를 좀 과하게 받나 싶기도 합니다,,
theme 바로 적용하려고 props 일관성을 좀 못 지킨 것 같은데 얘네 한번씩 봐주시면 감사하겠습니다!!
관련 이슈
close #43
스크린샷