[FEAT] theme button 색상값 적용 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrryu09
reviewed
Jul 7, 2024
src/styles/theme.ts
Outdated
Comment on lines
4
to
20
| // LIGHT | ||
| LIGHT: { | ||
| ICON: { | ||
| GREY_04: '#C6C6D0', | ||
| GREY_05: '#9090A0', | ||
| GREY_06: '#626273', | ||
| WHITE: '#FFFFFF', | ||
| }, | ||
| BG: { | ||
| BLUE_03: '#C2D5FF', | ||
| GREY_01: '#F4F6FA', | ||
| GREY_03: '#E9E9EE', | ||
| GREY_06: '#626273', | ||
| GREY_07: '#464656', | ||
| }, | ||
| }, | ||
| DEFAULT: { |
There was a problem hiding this comment.
BLUE:
LIGHT:
ICON: WHITE(색상이름, 기존 테마에 없으면 생성, 있으면 색 같은 이름으로 갖다쓰기)
BG: 색상이름
DEFAULT:
ICON:
BG:
WHITE:
...
BLACK:
...
이런 식으로 만드는 게 더 편하지 않을까요?
사실 테마 설정을 light 인지 디폴트인지만 알면 어떤 색상인지 이름 몰라도 바로 적용되는 편리함이 있어 사용하는 건데 지금 형태로는 카테고리를 골라서 직접 색상 보고 골라야 할 것 같아서 구조 제안드립니당!!
There was a problem hiding this comment.
기존 테마에 없음 생성은 palette 안에 새로운 이름으로 생성 말하는 거예요!!!
읽어보시구 더 나은 구조 있으면 제안주셔요!!!
There was a problem hiding this comment.
구조 변경했습니다! 승연이 버튼에만 해당하는 거라서, 내일 디자인 시스템 나오는 거 보고 없는 색상은 따로 palette에 추가하면 될 것 같아용 (제 버튼에 쓰이는 색상 말입니더 ㅎㅎ)
disabled / default / hover / pressed에서 갖다 쓰시면 될 것 같아용
jeeminyi
force-pushed
the
init/#44/theme-setting
branch
from
49c4b28
to
2c2e8a0
Compare
wrryu09
approved these changes
Jul 7, 2024
Kjiw0n
approved these changes
Jul 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 🧑💻
${({ theme }) => theme.button.light/default/hover/pressed.icon/bg}관련 이슈
close #44