[FIX] develop에 PR 시 action 스킵되는 오류 수정 #34
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 🧑💻
if문이 develop 브랜치가 PR을 올릴 때 액션이 돌아가도록 설정되어있어서ㅜㅜ, 해당 부분 삭제하였습니다!
yarn test
부분도 삭제하였습니다! 추후에 테스트 설정 시 추가하면 될 것 같아요알게된 점 🚀
github.ref
는 PR의 헤드 브랜치가 되며,github.base_ref
가 타겟 브랜치(이 경우엔 develop)라는 구분을 알았다!https://velog.io/@excellent/Github-Action-Context
https://docs.github.com/ko/actions
(처음 논의한 의도대로 on 으로 설정한 모든 경우에 ci도 돌아가도록 if 문을 삭제하였습니다)
리뷰 요구사항 💬
관련 이슈
close #33
스크린샷 (선택)
문제 상황