Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Dumping Area Task 생성 기능 연결 #338

Merged
merged 21 commits into from
Jan 13, 2025
Merged

[FEAT] Dumping Area Task 생성 기능 연결 #338

merged 21 commits into from
Jan 13, 2025

Conversation

wrryu09
Copy link
Member

@wrryu09 wrryu09 commented Jan 12, 2025 •
edited
Loading

작업 내용 🧑‍💻

  • task list 조회, task 추가 api 를 연결했습니다.
  • sortingOrder 쪽 타입 수정, 모달 수정

리뷰 요구사항 💬

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • 추가할 경우 기타 모달에서 넘어오는 정보는 null 로 가게 넣어줬으니 모달 연결할 때 붙여야 합니당..
  • sortinOrder 모달 위치 조정 필요

관련 이슈

close #335

스크린샷 (선택)

@wrryu09 wrryu09 self-assigned this Jan 12, 2025
@wrryu09 wrryu09 linked an issue Jan 12, 2025 that may be closed by this pull request
[FEAT] Dumping Area Task 생성 기능 연결 #335
Closed
@github-actions GitHub Actions
Copy link

🚀 Storybook 🚀

@github-actions GitHub Actions
Copy link

🚀 Storybook 🚀

jeeminyi
jeeminyi approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@jeeminyi jeeminyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅜ ㅜ ㅈㅅ해요 선 어푸합니다 고생하셨어요!!!!

Kjiw0n
Kjiw0n approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@Kjiw0n Kjiw0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작동 잘 되는 것 확인했습니다!! 수고많으셨어요

인풋창 입력 시 텍스트 초기화 안되는 부분만 체크 부탁드려요! 모달 화이띵... 💪

@github-actions GitHub Actions
Copy link

🚀 Storybook 🚀

@wrryu09
Merge pull request #340 from TEAM-DAWM/feat/#339/task-order-custom
6b27e04 
[FEAT] 사용자 설정 정렬 리스트 생성
@github-actions GitHub Actions
Copy link

🚀 Storybook 🚀

@wrryu09 wrryu09 merged commit b6cd2be into develop Jan 13, 2025
4 checks passed
@wrryu09 wrryu09 deleted the feat/#335/dumping-area-create-task branch January 13, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeeminyi jeeminyi jeeminyi approved these changes

@Kjiw0n Kjiw0n Kjiw0n approved these changes

@seong-hui seong-hui Awaiting requested review from seong-hui

Assignees

@wrryu09 wrryu09

Labels
🔗 api 연결 v2 😻 승연
Projects
@DAWM-FE
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Dumping Area Task 생성 기능 연결
3 participants
@wrryu09 @Kjiw0n @jeeminyi