Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STYLE] add color token #303

Merged
merged 3 commits into from
Nov 28, 2024
Merged

[STYLE] add color token #303

merged 3 commits into from
Nov 28, 2024

Conversation

Kjiw0n
Copy link
Contributor

@Kjiw0n Kjiw0n commented Nov 27, 2024

작업 내용 🧑‍💻

  • 피그마 시스템에 따라 colorToken을 theme에 새로 추가했습니다.
  • font.ts에서 font-weight이 적용 안되는 부분 추가했습니다.
  • font.ts에서 font-family 대체폰트 추가했습니다. (사파리에서 pretendard가 안먹음)

알게된 점 🚀

기록하며 개발하기!

리뷰 요구사항 💬

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • 중복되는 색상이 많지만 개발 편의를 위해 🥹🥹 colorToken 추가했습니다!

관련 이슈

close #302

스크린샷 (선택)

스크린샷 2024-11-28 00 33 43

Copy link

Copy link
Member

@wrryu09 wrryu09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 !!! 이제 색상설정 편하게 할 수 있겠네요🥹 고생하셧슴다👍

Copy link
Member

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컬러 토큰을 너무 잘 넣어주셔서 작업하기 훨씬 수월하겠네요!! 고생하셨습니다! 👍

@Kjiw0n Kjiw0n merged commit 0c83696 into develop Nov 28, 2024
5 checks passed
@Kjiw0n Kjiw0n deleted the style/#302/color-theme branch November 28, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[STYLE] color theme 추가
3 participants