Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] TimeBlock 삭제 방식 개선 #239

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[REFACTOR] TimeBlock 삭제 방식 개선 #239

merged 1 commit into from
Jul 19, 2024

Conversation

Kjiw0n
Copy link
Contributor

@Kjiw0n Kjiw0n commented Jul 19, 2024

작업 내용 🧑‍💻

TimeBlock 삭제 방식을 개선하였습니다.

  • 기존: 상세정보 모달의 삭제버튼을 통해 제거
  • 현재: TimeBlock 클릭 시 삭제 모달 바로 띄움

알게된 점 🚀

기록하며 개발하기!

  • 로직을 개선시켰습니다!

리뷰 요구사항 💬

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • 로직을 개선시켰습니다! 더블클릭이 아닌 클릭 시 모달을 띄우는 것으로 결정되었습니다.

관련 이슈

close #233

스크린샷 (선택)

Jul-19-2024 19-17-46

@Kjiw0n Kjiw0n self-assigned this Jul 19, 2024
seong-hui
seong-hui approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모달을 띄우는 것 보다 이렇게 버튼만 띄우는 게 훨씬 좋은 것 같습니다! 모달 위치를 위해서 window의 높이를 가져와서 구한 방식도 좋은 것 같습니다!! 수고하셨습니다 👍

wrryu09
wrryu09 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@wrryu09 wrryu09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@Kjiw0n Kjiw0n merged commit c45c09a into develop Jul 19, 2024
2 checks passed
@Kjiw0n Kjiw0n deleted the refactor/#233-timeblock-delete branch July 19, 2024 11:35
@pepperdad
Copy link

멋저요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrryu09 wrryu09 wrryu09 approved these changes

@seong-hui seong-hui seong-hui approved these changes

@jeeminyi jeeminyi Awaiting requested review from jeeminyi

Assignees

@Kjiw0n Kjiw0n

Labels
⭐️ 기능 추가 🍀 지원
Projects
@DAWM-FE
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Task 타임블로킹 삭제 방식 개선
4 participants
@Kjiw0n @pepperdad @seong-hui @wrryu09