Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] BtnTask 호버 완료버튼 뮤테이션 연결 #227

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

wrryu09
Copy link
Member

@wrryu09 wrryu09 commented Jul 19, 2024

작업 내용 🧑‍💻

BtnTask 호버 완료버튼 뮤테이션 연결했습니다

리뷰 요구사항 💬

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • 명세에 따라 공사 예정

관련 이슈

close #224

스크린샷 (선택)

Copy link
Member

@jeeminyi jeeminyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

레전드 프롭스 드릴링 발생,,ㅜㅜ 너무 고생하셨습니다 슬퍼

Copy link
Contributor

@Kjiw0n Kjiw0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

props drilling 큰일났네요... 개선 방법 저도 계속 생각해보겠습니다!

@@ -19,6 +19,7 @@ interface BtnTaskProps extends TaskType {
btnStatus?: string;
preventDoubleClick?: boolean;
isDragging?: boolean;
targetDate: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

targetDate가 null인 경우도 있으니까 옵셔널로 지정하고 디폴트값을 null로 설정해도 좋을 것 같습니다 !!

빌드 에러도 잡을 겸!

@wrryu09 wrryu09 merged commit 405d469 into develop Jul 19, 2024
2 checks passed
@wrryu09 wrryu09 deleted the feat/#224/hover-btn-api branch July 19, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEAT] BtnTask 호버 아이콘 클릭 시 상태 수정
3 participants