Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 승연이의 짬뽕탕 (태스크 생성 기한 설정 모달 값 입력 이슈 & UI 수정사항 & 불필요한 값 삭제) #223

Merged
merged 9 commits into from
Jul 19, 2024

Conversation

wrryu09
Copy link
Member

@wrryu09 wrryu09 commented Jul 19, 2024

작업 내용 🧑‍💻

  • 불필요한 중간 time, date state 저장 삭제
  • 모달 두개가 중복되어 하나 삭제
  • 스크롤 그라디언트 스테이징 에리아에 추가함
  • 태스크 추가 이름 비어있지 않을 때만 요청가게 함

리뷰 요구사항 💬

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • box-sizing 관련 스타일 문제있는지,
  • state 와 모달 삭제 구조 변경으로 인한 사이드이펙트 없는지 검토해주시면 감사하겠습니다

관련 이슈

close #222

스크린샷 (선택)

@jeeminyi jeeminyi changed the title [BUG] 태스크 생성 기한 설정 모달 값 입력 이슈 [BUG] 승연이의 짬뽕탕 (태스크 생성 기한 설정 모달 값 입력 이슈 & UI 수정사항 & 불필요한 값 삭제) Jul 19, 2024
Copy link
Member

@jeeminyi jeeminyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

</>
)}
</ScrollArea>
{!isError && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is error로 한번 감싸주셨구었군요! 좋습니다,, 굿 짱

@@ -75,6 +78,7 @@ const TaskLayout = styled.div`
box-sizing: border-box;
width: 41.7rem;
height: 41rem;
padding: 0 0 0 6px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅜㅜ 왜 바져있었을까용 ㅜ

@@ -28,7 +28,7 @@ const ScrollGradientTop = styled.div`
width: 100%;
height: 2.2rem;

background: linear-gradient(180deg, rgb(255 255 255 / 0%) 0%, ${({ theme }) => theme.palette.Grey.White} 65.91%);
background: linear-gradient(180deg, rgb(255 255 255 / 0%) 0%, #fff 100%);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 이슈가 있었군요,,

@@ -46,6 +47,7 @@ function StagingAreaTaskContainer({ handleSelectedTarget, selectedTarget, tasks
)}
</Draggable>
))}
<ScrollGradient />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿~ 자바리

@@ -55,7 +55,7 @@ const DashBoardLayout = styled.div`
display: flex;
flex-direction: column;
width: 127.8rem;
height: 100vh;
height: 100%;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

죄송합니다 ㅠㅠ

Copy link
Member

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모달이 2개가 연결이 되어있어서 버튼을 클릭시에 모달이 이상하게 반영되고 있었군요 해당 버그 잘 수정하시느라 고생 많으셨씁니다. 짱짱! 👍

@seong-hui seong-hui merged commit 77a7ab9 into develop Jul 19, 2024
2 checks passed
@seong-hui seong-hui deleted the fix/#222/createtask-modal-timevalue branch July 19, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] 태스크 생성 기한 설정 모달 값 입력 이슈
3 participants