[FEAT] Task 타임블로킹 삭제 api 연결 #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrryu09
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
기존에 같은 id 가진 이벤트가 캘린더에 있다면 삭제 주석 달아둔 부분에도 삭제 기능이 달려야 할 것 같습니다!
오늘 안에 한 태스크를 한번만 긁을 수 있기 때문에 새로 긁으면 기존에 있던 블럭이 지워져야 해서 이쪽에 그 처리를 해주면 될 것 같아요
Comment on lines
+11
to
+19
| interface TasksEventData { | ||
| taskId: number; | ||
| timeBlockId: number; | ||
| title: string; | ||
| start: string; | ||
| end: string; | ||
| allDay?: boolean; | ||
| classNames: string; | ||
| } |
There was a problem hiding this comment.
Suggested change
| interface TasksEventData { | |
| taskId: number; | |
| timeBlockId: number; | |
| title: string; | |
| start: string; | |
| end: string; | |
| allDay?: boolean; | |
| classNames: string; | |
| } | |
| interface TasksEventData extends EventData { | |
| taskId: number; | |
| timeBlockId: number; | |
| } |
여기 인터페이스 상속으로 이렇게 써줄 수 있을 것 같네요!
Comment on lines
145
to
148
| const removeTimezone = (str: string) => str.replace(/:\d{2}[+-]\d{2}:\d{2}$/, ''); | ||
|
|
||
| const startStr = removeTimezone(selectInfo.startStr); | ||
| const endStr = removeTimezone(selectInfo.endStr); |
jeeminyi
approved these changes
Jul 19, 2024
| @@ -199,15 +213,15 @@ function FullCalendarBox({ size, selectDate, selectedTarget }: FullCalendarBoxPr | |||
| eventClick={handleEventClick} | |||
| select={addEventWhenDragged} | |||
| /> | |||
| {isModalOpen && ( | |||
| // 🚨 임시 taskID ... 데이터 형식 확정 후 수정할 것 🚨 | |||
| {isModalOpen && modalTaskId !== null && modalTimeBlockId !== null && ( | |||
There was a problem hiding this comment.
모달 테스크 아이디와 타임블록 아이디가 존재할 때만 모달이 열리도록 처리해주셨군용! 쪼아요
Comment on lines
+11
to
+19
| interface TasksEventData { | ||
| taskId: number; | ||
| timeBlockId: number; | ||
| title: string; | ||
| start: string; | ||
| end: string; | ||
| allDay?: boolean; | ||
| classNames: string; | ||
| } |
seong-hui
approved these changes
Jul 19, 2024
| /** TimeBlock 삭제 */ | ||
| const useDeleteTimeBlock = () => { | ||
| const queryClient = useQueryClient(); | ||
| const mutation = useMutation({ |
There was a problem hiding this comment.
태스크 삭제 적용까지 시간이 많이 걸려서 isLoading이면 스피너를 추가하면 더욱 좋을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 🧑💻
알게된 점 🚀
리뷰 요구사항 💬
관련 이슈
close #214
스크린샷 (선택)