Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Time-block 리스트 조회 #211

Merged
merged 8 commits into from
Jul 18, 2024

Conversation

Kjiw0n
Copy link
Contributor

@Kjiw0n Kjiw0n commented Jul 18, 2024

작업 내용 🧑‍💻

  • Time-block 리스트 조회
  • time-block data 가져오는 부분에 연결

알게된 점 🚀

기록하며 개발하기!

  • data 가공하는 법에 대해 보다 더 잘 알게 되었습니다~~

리뷰 요구사항 💬

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

  • 캘린더 스타일 적용이 안됩니다..!

관련 이슈

close #193

스크린샷 (선택)

Jul-19-2024 00-49-26

@Kjiw0n Kjiw0n force-pushed the feat/#193-api-timeblock-list-get branch from efc48aa to 34f3433 Compare July 18, 2024 15:52
Copy link
Member

@jeeminyi jeeminyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨듭니다! 레전드 개발~자

Comment on lines +14 to +24
// tasks 데이터 처리
timeBlockData.tasks.forEach((task) => {
task.timeBlocks.forEach((timeBlock) => {
events.push({
title: task.name,
start: timeBlock.startTime,
end: timeBlock.endTime,
classNames: 'tasks',
});
});
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드가 예뻐요.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅇㅈ

@Kjiw0n Kjiw0n force-pushed the feat/#193-api-timeblock-list-get branch from 669bc10 to 1ff34ea Compare July 18, 2024 17:04
Copy link
Member

@seong-hui seong-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

풀캘린더 라이브러리 이벤트 형식에 맞추기 위해서 데이터를 가공하는 과정이 필요했는데 그 부분을 잘 해주셔서 캘린더 연동이 잘 된 것 같습니다! 해당 부분 구현하시느라 고생 많으셨습니다!!

@seong-hui seong-hui merged commit bba2aeb into develop Jul 18, 2024
2 checks passed
@seong-hui seong-hui deleted the feat/#193-api-timeblock-list-get branch July 18, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEAT] Time-block 리스트 조회 api 연결
4 participants