[FEAT] today 페이지의 날짜 이동 기능 #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrryu09
approved these changes
Jul 17, 2024
Comment on lines
12
to
13
| onClickPrevDate: (day: number) => void; | ||
| onClickNextDate: (day: number) => void; |
There was a problem hiding this comment.
아쉽게도 버튼 형식을 맞추기 위해 오히려 함수가 늘어났다는 사실 ...
Comment on lines
+41
to
+42
| <ArrangeBtn color="BLACK" mode="DEFAULT" size="small" type="left" onClick={onClickPrevDate} /> | ||
| <ArrangeBtn color="BLACK" mode="DEFAULT" size="small" type="right" onClick={onClickNextDate} /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용 🧑💻
알게된 점 🚀
-
<Button onClick={onClickChangeDate(-1)}>처음에 이런식으로 함수를 전달하고자하니 무한히 재렌더링되므로 "Too many re-renders" 오류가 발생하였습니다. 위의 코드는 onClickChangeDate 함수가 즉시 실행되며, 반환된 값이 onClick 이벤트 핸들러로 설정되어 무한 루프가 발생하는 것이었습니다.<Button onClick={() => onClickChangeDate(-1)}>따라서 함수를 화살표 함수로 감싸 전달하여 실제로 버튼이 클릭될 때만 함수가 실행되도록 하였습니다.
리뷰 요구사항 💬
관련 이슈
close #168
스크린샷 (선택)
Screen.Recording.2024-07-17.at.7.32.09.PM.mov