Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨[refractor][made changes for tests] #409

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

Ankitv003
Copy link
Contributor

@Ankitv003 Ankitv003 commented Nov 1, 2024

fix #85
@blackgirlbytes please check this pr!

@blackgirlbytes
Copy link
Contributor

looking!

@Ankitv003
Copy link
Contributor Author

changed to pnpm , hope this works !

@Ankitv003
Copy link
Contributor Author

installed pnpm locally

@Ankitv003
Copy link
Contributor Author

hey @blackgirlbytes , can you check this time?

Copy link
Contributor

@blackgirlbytes blackgirlbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's looking good! Amazing job at staying persistent and thanks for your contribution.

@blackgirlbytes blackgirlbytes merged commit 45f5e1c into TBD54566975:main Nov 6, 2024
21 checks passed
@Ankitv003
Copy link
Contributor Author

Awesome!🎉 Thanks for all the help @blackgirlbytes🙌 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure Vanilla.js app to be a PWA
2 participants