fix: delete async call with the cron job (#3127)

backend/controller/cronjobs/internal/dal/dal.go

@@ -102,7 +102,11 @@ func (d *DAL) UpdateCronJobExecution(ctx context.Context, params UpdateCronJobEx
 }
 
 func (d *DAL) DeleteCronJobsForDeployment(ctx context.Context, key model.DeploymentKey) error {
-	err := d.db.DeleteCronJobsForDeployment(ctx, key)
+	err := d.db.DeleteCronAsyncCallsForDeployment(ctx, key)
+	if err != nil {
+		return fmt.Errorf("failed to delete cron job async calls for deployment %v: %w", key, libdal.TranslatePGError(err))
+	}
+	err = d.db.DeleteCronJobsForDeployment(ctx, key)
 	if err != nil {
 		return fmt.Errorf("failed to delete cron jobs for deployment %v: %w", key, libdal.TranslatePGError(err))
 	}

backend/controller/cronjobs/internal/sql/queries.sql

@@ -52,4 +52,13 @@ SELECT EXISTS (
 
 -- name: DeleteCronJobsForDeployment :exec
 DELETE FROM cron_jobs
-WHERE deployment_id = (SELECT id FROM deployments WHERE key = sqlc.arg('deployment_key')::deployment_key LIMIT 1);
+WHERE deployment_id = (SELECT id FROM deployments WHERE key = sqlc.arg('deployment_key')::deployment_key LIMIT 1);
+
+
+-- name: DeleteCronAsyncCallsForDeployment :exec
+DELETE FROM async_calls
+WHERE id IN (
+  SELECT last_async_call_id
+  FROM cron_jobs
+  WHERE deployment_id = (SELECT id FROM deployments WHERE key = sqlc.arg('deployment_key')::deployment_key LIMIT 1)
+);