Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

62, 1875: Hide search box filter. #64

Merged
merged 2 commits into from
Apr 23, 2024
Merged

62, 1875: Hide search box filter. #64

merged 2 commits into from
Apr 23, 2024

Commits on Nov 27, 2023

  1. Issue: Search Box does not appear after selecting it in the filter of… 

    … the admin list.

This is the first solution described below that fully hides the "Search Box" from the filter list to avoid this confusion.
The previous solution of hiding the "Search Box" is incomplete and still displays the "Search Box" in the "Disabled Filters" column.
The "Search Box" is filtered out of the "Disabled Filters" by this commit.

The following are the results of the investigation into this problem:
The Search Box filter, when selected, gets saved to the database and returned to the UI on an appropriate `/submission-list/filter-columns-by-user` call.

What is happening is that the Search Box is explicitly being removed from the filter list:
- https://github.com/TexasDigitalLibrary/Vireo/blob/61fb5873989eee667951f7b80244fa4f91c084ea/src/main/webapp/app/controllers/submission/submissionListController.js#L150

And then later is handled differently as an "Excluded Column":
- https://github.com/TexasDigitalLibrary/Vireo/blob/db2b4cacea96a29912138626fe1ed5985cb5d073/src/main/webapp/app/controllers/submission/submissionListController.js#L172

It appears to be originally added here with the exluded column:
- TexasDigitalLibrary@c39ff04
- TexasDigitalLibrary#285

Vireo Slack messages relating to Search Box:
- https://texas-digital-library.slack.com/archives/C7R78CADB/p1550676084006100
- https://texas-digital-library.slack.com/archives/C7R78CADB/p1682428409804819?thread_ts=1682428314.318099&cid=C7R78CADB
- https://texas-digital-library.slack.com/archives/C7R78CADB/p1550696674010100

Referenced Github issues from the conversations:
- TexasDigitalLibrary#1146
    @kaladay
    kaladay committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    5578226 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge remote-tracking branch 'kaladay/turkey_trot_2024-search_box_bug… 

    …-approach_1' into 1875-hide_search_filter
    @kaladay
    kaladay committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0c71aca View commit details
    Browse the repository at this point in the history