Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

62, 1875: Hide search box filter. #64

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Conversation

kaladay
Copy link

@kaladay kaladay commented Apr 22, 2024

Resolves #62
Resolves TexasDigitalLibrary#1875

… the admin list.

This is the first solution described below that fully hides the "Search Box" from the filter list to avoid this confusion.
The previous solution of hiding the "Search Box" is incomplete and still displays the "Search Box" in the "Disabled Filters" column.
The "Search Box" is filtered out of the "Disabled Filters" by this commit.

The following are the results of the investigation into this problem:
The Search Box filter, when selected, gets saved to the database and returned to the UI on an appropriate `/submission-list/filter-columns-by-user` call.

What is happening is that the Search Box is explicitly being removed from the filter list:
- https://github.com/TexasDigitalLibrary/Vireo/blob/61fb5873989eee667951f7b80244fa4f91c084ea/src/main/webapp/app/controllers/submission/submissionListController.js#L150

And then later is handled differently as an "Excluded Column":
- https://github.com/TexasDigitalLibrary/Vireo/blob/db2b4cacea96a29912138626fe1ed5985cb5d073/src/main/webapp/app/controllers/submission/submissionListController.js#L172

It appears to be originally added here with the exluded column:
- TexasDigitalLibrary@c39ff04
- TexasDigitalLibrary#285

Vireo Slack messages relating to Search Box:
- https://texas-digital-library.slack.com/archives/C7R78CADB/p1550676084006100
- https://texas-digital-library.slack.com/archives/C7R78CADB/p1682428409804819?thread_ts=1682428314.318099&cid=C7R78CADB
- https://texas-digital-library.slack.com/archives/C7R78CADB/p1550696674010100

Referenced Github issues from the conversations:
- TexasDigitalLibrary#1146
@kaladay kaladay requested a review from jsavell April 22, 2024 14:59
@kaladay kaladay changed the title 62, 1875: Hide search bar. 62, 1875: Hide search box filter. Apr 22, 2024
@kaladay kaladay merged commit 8222da3 into sprint1-staging Apr 23, 2024
0 of 2 checks passed
@kaladay kaladay linked an issue Apr 23, 2024 that may be closed by this pull request
@jsavell jsavell mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar not appearing under customize filters
2 participants