Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecated docker-compose command #482

Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix: deprecated docker-compose command #482

merged 2 commits into from
Oct 17, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Sep 17, 2024 •
edited
Loading

Overview

  • Do not use deprecated docker-compose command.
  • Do use Docker Compose v2+ command, docker compose.

Important

Command docker-compose fails in latest versions of Docker Compose.

Related

Changes

  • replaced docker-compose with docker compose

Testing

Newer Docker Compose

  1. Have Docker-Compose v2 (latest or relatively new).
  2. Run any npx nx serve … command.
  3. Verify no error about docker-compose command.

Older Docker Compose

  1. Have Docker-Compose v2 (older version).
  2. Run any npx nx serve … command.
  3. Verify no error about docker-compose command.

UI

Skipped.

@wesleyboar wesleyboar marked this pull request as ready for review September 17, 2024 22:42
@wesleyboar wesleyboar requested a review from jarosenb September 17, 2024 22:42
@jarosenb jarosenb merged commit f6abca1 into main Oct 17, 2024
1 check passed
@jarosenb jarosenb deleted the fix/deprecated-docker-compose-command branch October 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarosenb jarosenb jarosenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @jarosenb