Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: CMD-171 svgs & icons not accessible #470

Merged
merged 3 commits into from
Jul 10, 2024
Merged

fix: CMD-171 svgs & icons not accessible #470

merged 3 commits into from
Jul 10, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 9, 2024 •
edited
Loading

Overview

SVGs and icons are now accessible.

Related

Changes

  • added role attribute and title tag

Testing

  1. Verify markup has changed.
  2. Verify affected graphics have accessible role and title.
  3. Verify images still display as they had.

UI

Skipped.

@wesleyboar wesleyboar mentioned this pull request Jul 9, 2024
Merged
@jarosenb jarosenb merged commit ff93a75 into main Jul 10, 2024
1 check passed
@jarosenb jarosenb deleted the fix/CMD-171-svgs-not-accessible branch July 10, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarosenb jarosenb jarosenb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @jarosenb