fix(lccf): cms menu .nav-link alignment

[wesleyboar]

Overview

For LCCF, fix vertical alignment of .nav-links in CMS menu.

This is a problem on all sites using TACC_CORE_STYLES_VERSION = 2 but is most-noticeable on LCCF, because LCCF sets .s-header.navbar { --nav-padding-vert: 10px; } (and .s-header .nav-link { top: unset; } to partially resolve alignment.)

Warning

Introduces nav link height bug on "mobile" navbar, but will be fixed by TACC/Core-Styles#427.

Related

• fixes feat: ctrn_assets & LCCF header CSS #325
• fixed by fix: s-header nav-link alignment inconsistent Core-Styles#427

Changes

• fixes .s-header .nav-link styles
  ^{(in a way that should be applied to Core-Styles instead)}

Testing & UI

LCCF Custom Styles

1. Replace the content of LCCF's header.css with the new content.
2. Verify .nav-link underline is at bottom of header.
3. Verify .nav-link text is vertically aligned center with search bar.

apply.updated.header.css.to.lccf.mov

Default CMS & Styles

1. Add styles /* To fix nav link alignment regardless the nav padding */
2. Verify .nav-link underline is at bottom of header.
3. Verify .nav-link text is vertically aligned center with search bar. larger */`.

apply.core-styles.fix.to.cep.mov