small QoL additions for running a SysML-v2 API server #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2024 14:29
This commit adds the `junixsocket` library to the dependencies. This allows the usage of a UNIX domain socket connection to a `postgresql` server. This promises both better performance, and it allows to use a Linux user identity for authentication against the DB (versus username/password auth for TCP/IP based communication to the DB). The change is non-intrusive, i.e. per default TCP/IP is still used and works as intended. For more information, checkout: - https://jdbc.postgresql.org/documentation/use/#unix-sockets - https://kohlschutter.github.io/junixsocket/dependency.html#postgresql In particular, setting the following two properties in the `persistence.xml` suffices to connect to a postgresql via a socket file: ``` javax.persistence.jdbc.url='jdbc:postgresql://localhost/db-name?socketFactory=org.newsclub.net.unix.AFUNIXSocketFactory$SystemProperty' org.newsclub.net.unix.socket.default=/run/postgresql/.s.PGSQL.5432 ```
Prior to this change, the only way to change the persistence settings was to edit the `persistence.xml`. In case of a pre-build .jar, the `persistence.xml` has to be contained in the .jar with the persistence module [1], and can not be overridden. However, the current repo hard-codes the DB connection details in the persistence.xml, which makes it impossible to override the DB connection details for a fully built .jar without changing that .jar file. This change enable the overriding of the properties used for the JPA `EntityManagerFactory` with system properties, so that DB connection details can be altered without changing the .jar file. [1] https://openjpa.apache.org/builds/1.0.2/apache-openjpa-1.0.2/docs/manual/ref_guide_conf_specify.html
|
Thank you for your interest in creating this proposed update. However, we are not accepting pull requests from outside our development team at this time. But, if you submit your proposal as a GitHub issue with your proposal, then we can add it to our internal development backlog to be considered for inclusion in a future release. |
|
@seidewitz Thank you for the quick answer. What a bummer. Anyhow, I quickly created #110 and #111. Is there any eta when/if the development will be opened up further? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While setting up our API server for some toying around, there where some things that bugged us around the database setup. These two commits address our pain-points. As both changes should not break any existing behavior, we would like to upstream them. I'd be happy for a review, @ivan-gomes 😄