human v1.0.1 #97
Merged
human v1.0.1 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with an exact copy of RAVEN's writeYaml function.
- All "names:" entries are now enclosed in double quotes. - Subsystems have been converted to lists, even when they contain one value. - All "annotation:" fields are now excluded from the yaml.
Much of the metadata is currently hard-coded, but this can be updated with future model iterations.
- Instead of manually coding the necessary metadata, now arrange these info into the existing fields in RAVEN and extract out accordingly by this refactoring.
- Change filename from issue71 to addMetaData
Additional changes with consensus are added here: - Reformat EC-number in eccodes field - Remove rxnComps field - Turn `version` into a blank field - Initialize rxnConfidenceScores field with zero
feat: add metadata and miscellaneous adjustments
This update is implemented by running script `miscModelCurationScript_20190323.m`: - metadata is incoporated both in mat and yaml files according to #71 - reformat EC-number in `eccodes` field, as discussed in #93 - remove `rxnComps` field, according to #184 in RAVEN - empty `version` field to enable a simple and clear work flow - initialize `rxnConfidenceScores` field with zero, as discussed in #48
- Adapt from RAVEN function exportForGit
feat: enable automatic human-GEM release
JonathanRob
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
Yamlformat file by new functionwriteHumanYamlmiscModelCurationScript_20190323exportHumanGEMand adjustincreaseHumanGEMVersionfor enabling automatic model releaseI hereby confirm that I have:
develas a target branch