Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump workflow dependency version #512

Merged
merged 6 commits into from
Oct 20, 2023
Merged

Conversation

mihai-sysbio
Copy link
Member

@mihai-sysbio mihai-sysbio commented Mar 23, 2023

Main improvements in this PR:

This PR aims to update the dependencies of GH workflows.

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

@mihai-sysbio mihai-sysbio force-pushed the chore/update-workflow branch from 574089d to 88ca1a6 Compare March 23, 2023 10:40
@mihai-sysbio
Copy link
Member Author

Note: this PR should stay as draft until the yaml-validation passes. The current version seems to have problems that are out of our control.

@mihai-sysbio
Copy link
Member Author

The problem seems to originate in the yaml-validation action, and there is a pending PR for it ibiqlik/action-yamllint#38.

@mihai-sysbio mihai-sysbio force-pushed the chore/update-workflow branch 2 times, most recently from 30e1794 to a8e5852 Compare October 6, 2023 08:47
@mihai-sysbio mihai-sysbio marked this pull request as ready for review October 6, 2023 09:31
Copy link
Member

@haowang-bioinfo haowang-bioinfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's okay to step away from ibiqlik, which apears to be very slow

@mihai-sysbio mihai-sysbio merged commit 5ed02a0 into develop Oct 20, 2023
8 checks passed
@mihai-sysbio mihai-sysbio deleted the chore/update-workflow branch October 20, 2023 07:18
@mihai-sysbio
Copy link
Member Author

Thanks for the review @haowang-bioinfo, I've merged this PR.

Indeed, it seemed that there was very little activity in the original repository, which is why I've forked that repository and published that a new GH Action which is used in this PR.

@haowang-bioinfo
Copy link
Member

Indeed, it seemed that there was very little activity in the original repository, which is why I've forked that repository and published that a new GH Action which is used in this PR.

probably consider centralizing all used GH actions for convenient maintenance

@haowang-bioinfo haowang-bioinfo mentioned this pull request Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants