Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
loadDatabases
clarifies what to do if download from UniProt fails.calculateFfactor
sometimes failed to properly readpaxDB.tsv
files.runDLKcat
should parseparams.path
as absolute paths to docker (solves runDLKcat() cannot find path to data #378).applyKcatConstraints
can handle when all kcat are zero.getStandardKcat
should also assign standard kcat values for reactions that do have a non-emptygrRules
field, but are not inmodel.ec
due to the genes not matching any of the enzymes in theuniprot.tsv
file.removeStandardKcat
function removes all traces ofgetStandardKcat
having modified a model.Instructions on merging this PR:
develop
as target branch, and will be resolved with a squash-merge.main
as target branch, and will be resolved with a merge commit.