Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProtPool Calculation by Including usage_prot_ Reaction Fluxes #372

Merged
merged 12 commits into from
May 8, 2024

Conversation

HossFir
Copy link

@HossFir HossFir commented Apr 18, 2024

Description:

Issue:
The original implementation of topEnzymeUsage function calculates protPool by only considering the prot_pool_exchange flux. However, this does not reflect the total enzymatic capacity used by the metabolic reactions, especially when proteomics data is integrated into the model.

Enhancement:
The function has been enhanced to account for the fluxes of all usage_prot_ reactions, excluding the ones related to usage_prot_standard.

Changes:

  1. Flux Calculation Integration: The function now includes a call to solveLP(ecModel) to calculate the flux distribution within the model.

  2. Targeted Flux Summation: After obtaining the flux distribution, the function identifies all usage_prot_ reactions while filtering out any that include standard in their reaction IDs. Since this reaction was embedded into Protein_pool_exchange.

  3. Adjusted protPool Definition: The protein pool (protPool) is redefined to be the sum of the prot_pool_exchange flux and the total usage fluxes.

edkerk and others added 8 commits July 17, 2023 12:10
* fix: loadDatabases check for duplicate protIDs (SysBioChalmers#349)

* fix: prevent NaN in light ecModels (SysBioChalmers#346)

* fix: calculateFfactor if paxDB has taxID !4 chars (SysBioChalmers#347)

* fix: runDLKcat if path has spaces (SysBioChalmers#352)

* refactor: FSEOF (SysBioChalmers#356)

* fix: FSEOF to 0.9 of teorethical max prod

* refactor: switch force objetive to target

* fix: remove unnecesary function

* fix: update input arguments

* fix: temporal solution k-score

* refactor: FSEOF

* feat: add gene essentiality to FSEOF

* fix: file writing

* feat: add cutoff based on quantile

* feat: report target transport reactions

* refactor: add cutoff for essentiality

* fix: bug identifying gene essentiality

* doc: move installations instructions to wiki (SysBioChalmers#357)

* move installation instructions to wiki

* GECKOInstaller checks for latest GECKO version

* fix: prevent duplications in protein pseudometabolites

* minor fixes

* doc: update documentation

* doc: swap gitter for GitHub Discussions

* fix: correct link to upgrade instructions

* fix: synchronize STEP numbers  protocol and paper

---------

Co-authored-by: Albert Tafur Rangel <[email protected]>
…g up protein pool exchange and proteomics integrated, adjusting 'percUsage' accordingly.
…g up protein pool exchange and proteomics integrated, adjusting 'percUsage' accordingly.
@edkerk edkerk changed the base branch from main to develop April 28, 2024 09:24
@edkerk
Copy link
Member

edkerk commented Apr 28, 2024

Nice work, I have a few suggested edits. Could you please give me the right to push to this by following these instructions?

edkerk added 2 commits April 28, 2024 14:41
- use fluxes from usageData
- give protein pool in usageReport instead of printing to command window
@edkerk
Copy link
Member

edkerk commented Apr 28, 2024

Suggested changes applied:

  • instead of running solveLP in reportEnzymeUsage, use the same solution as provided in the usageData that is now output by enzymeUsage.
  • instead of printing the total protein pool flux and total usageProt flux into the command window, have it as fields in the usageReport output structure.

@HossFir, can you check if this works for you? Should give the same results as your earlier code.

@HossFir
Copy link
Author

HossFir commented Apr 28, 2024

@edkerk Thanks for your suggestions!

The results were somehow identical! I've attached two TopUsed Enzymes for you to review.

topAbsUsage_stage4_PH.xlsx
topAbsUsage_stage4_PH2.xlsx

@edkerk edkerk merged commit cc8e449 into SysBioChalmers:develop May 8, 2024
1 check failed
edkerk added a commit that referenced this pull request May 27, 2024
@edkerk
Copy link
Member

edkerk commented May 27, 2024

This PR will be reverted, as the changes by #379 avoid this problem to occur. If kept, the new protein usage numbers would be too high, due to double counting vai the total protein usage and the protein specific usage reactions.

@edkerk edkerk mentioned this pull request May 27, 2024
2 tasks
edkerk added a commit that referenced this pull request May 27, 2024
* Revert "Merge pull request #372 from HossFir/update-reportEnzymeUsage"

This reverts commit cc8e449, reversing
changes made to 883b40d.

* fix: reportEnzymeUsage gives total protein usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants